Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 21 Aug 2023 17:49:33 GMT
From:      Fernando =?utf-8?Q?Apestegu=C3=ADa?= <fernape@FreeBSD.org>
To:        ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org
Subject:   git: 9318c43722de - main - devel/valgrind: do not strip binaries
Message-ID:  <202308211749.37LHnXc8062349@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by fernape:

URL: https://cgit.FreeBSD.org/ports/commit/?id=9318c43722de21851f11d4b66c6dd9f3b3ce07e9

commit 9318c43722de21851f11d4b66c6dd9f3b3ce07e9
Author:     Paul Floyd <pjfloyd@wanadoo.fr>
AuthorDate: 2023-08-21 06:46:22 +0000
Commit:     Fernando ApesteguĂ­a <fernape@FreeBSD.org>
CommitDate: 2023-08-21 17:49:20 +0000

    devel/valgrind: do not strip binaries
    
    Valgrind binaries should not be stripped (at least, not the preload shared
    libs).
    
    PR:             273243
    Reported by:    pjfloyd@wanadoo.fr (maintainer)
---
 devel/valgrind/Makefile | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/devel/valgrind/Makefile b/devel/valgrind/Makefile
index 391d437067f5..0eb2d678cbb1 100644
--- a/devel/valgrind/Makefile
+++ b/devel/valgrind/Makefile
@@ -1,5 +1,6 @@
 PORTNAME=	valgrind
 PORTVERSION=	3.21.0
+PORTREVISION=	1
 PORTEPOCH=	1
 CATEGORIES=	devel
 MASTER_SITES=	SOURCEWARE/valgrind
@@ -33,6 +34,14 @@ OPTIONS_DEFAULT_amd64=	32BIT
 .endif
 OPTIONS_SUB=		yes
 
+# Valgrind needs to read debuginfo from its own preload shared libraries
+# (quote from README_PACKAGERS
+#-- Don't strip the debug info off lib/valgrind/$platform/vgpreload*.so
+#   in the installation tree.  Either Valgrind won't work at all, or it
+#   will still work if you do, but will generate less helpful error
+#   messages.)
+STRIP=          # empty
+
 32BIT_DESC=	Enable debugging of 32-bit programs (requires lib32)
 MPI_DESC=	Enable build of MPI wrappers
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202308211749.37LHnXc8062349>