From owner-freebsd-current Mon Jan 27 8:58:37 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id A26FB37B401 for ; Mon, 27 Jan 2003 08:58:36 -0800 (PST) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2465143E4A for ; Mon, 27 Jan 2003 08:58:35 -0800 (PST) (envelope-from phk@freebsd.org) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id h0RGwTQl023746; Mon, 27 Jan 2003 17:58:30 +0100 (CET) (envelope-from phk@freebsd.org) To: "Peter Edwards" Cc: freebsd-current@freebsd.org Subject: Re: Opening /dev/tty in session leader after controlling terminal is revoked causes panic. From: phk@freebsd.org In-Reply-To: Your message of "Mon, 27 Jan 2003 16:49:45 GMT." <20030127164951.4B78643ED8@mx1.FreeBSD.org> Date: Mon, 27 Jan 2003 17:58:29 +0100 Message-ID: <23745.1043686709@critter.freebsd.dk> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20030127164951.4B78643ED8@mx1.FreeBSD.org>, "Peter Edwards" writes: >> >The problem is in kern/tty_tty.c:ctty_clone. It's assuming that if the process >> >has its P_CONTROLT flag set, then it's session has a valid vnode for it's >> >controlling terminal. This doesn't hold if the terminal was revoked. >Yes, this patch also fixes the problem. OK, committed! -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message