From owner-freebsd-current@FreeBSD.ORG Wed Aug 4 11:20:49 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 496E2106564A for ; Wed, 4 Aug 2010 11:20:49 +0000 (UTC) (envelope-from uqs@spoerlein.net) Received: from acme.spoerlein.net (acme.spoerlein.net [IPv6:2001:470:9a47::1]) by mx1.freebsd.org (Postfix) with ESMTP id B55E18FC19 for ; Wed, 4 Aug 2010 11:20:48 +0000 (UTC) Received: from acme.spoerlein.net (localhost.spoerlein.net [IPv6:::1]) by acme.spoerlein.net (8.14.4/8.14.4) with ESMTP id o74BIa5F056819 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 4 Aug 2010 13:18:36 +0200 (CEST) (envelope-from uqs@spoerlein.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=spoerlein.net; s=dkim200908; t=1280920716; bh=Ap2mZrk7R1G9pFuoe3lHD0LhTHML6LFq9hKVUcJZkCw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=uafHxtvgYnmFOr+JuYjlvS5OzpdPHSQS2c02atuujsjVthZo+AhI9DC9g++BhWAs9 Eb15M/T2FRwC68dKUU8OIUEhOkj25kudSoK2Uu7TJIU9noVuMYIeXdT3TbCVGcxZzA /MEZDm+/LA/6OShAzvbf6sigkV5FLsKIiirDQlqc= Received: (from uqs@localhost) by acme.spoerlein.net (8.14.4/8.14.4/Submit) id o74BIZ0l056818; Wed, 4 Aug 2010 13:18:35 +0200 (CEST) (envelope-from uqs@spoerlein.net) Date: Wed, 4 Aug 2010 13:18:35 +0200 From: Ulrich =?utf-8?B?U3DDtnJsZWlu?= To: Steve Kargl Message-ID: <20100804111835.GJ36735@acme.spoerlein.net> Mail-Followup-To: Steve Kargl , Thomas Dickey , FreeBSD Current , Julian Elischer References: <4C585E6C.7080006@elischer.org> <20100803214005.GA539@saltmine.radix.net> <20100804002145.GA76309@troutmask.apl.washington.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100804002145.GA76309@troutmask.apl.washington.edu> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: FreeBSD Current , Thomas Dickey , Julian Elischer Subject: Re: [patch] big whitespace cleanup in sys/kern/* X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Aug 2010 11:20:49 -0000 On Tue, 03.08.2010 at 17:21:45 -0700, Steve Kargl wrote: > On Tue, Aug 03, 2010 at 05:40:05PM -0400, Thomas Dickey wrote: > > On Tue, Aug 03, 2010 at 11:22:36AM -0700, Julian Elischer wrote: > > > On 8/3/10 2:34 AM, pluknet wrote: > > > >Hi. > > > > > > > >I looked into sys/kern/* files to fix a bunch of common w/s style issues > > > >(221): > > > >- leading space before label; > > > >- leading space(s) before; > > > >- space(s) instead of(s); > > > >- space(s) in blank like. > > > > > > > >I tried to be conservative and didn't touch semi-contrib files and > > > >those with its own style. > > > >Here is a diff I'd like someone look into and check in if there will > > > >no objections. > > > > > > The style guide suggests against wholesale cleanups and we have > > > generally avoided them due to teh fact that they tend to obfuscate diffs. > > > The idea being that we clean as we go.. > > > however it may be time for one.. I'd leave it to others to decide. > > > > I'm curious why there's no mention of using 'indent' (with appropriate > > settings...). > > > > Because there is no set of appropriate settings for indent(1) > to reproduce style(9). uncrustify (in ports) can be made to almost adhere to style(9). The documentation/configuration of that tool is horrible, though. I someone is interested in my uncrustify.cfg and wants to improve it, drop me a line. Uli