From owner-freebsd-testing@FreeBSD.ORG Thu Mar 6 18:09:32 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EA82064D for ; Thu, 6 Mar 2014 18:09:32 +0000 (UTC) Received: from mail-qa0-f41.google.com (mail-qa0-f41.google.com [209.85.216.41]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A30096C2 for ; Thu, 6 Mar 2014 18:09:32 +0000 (UTC) Received: by mail-qa0-f41.google.com with SMTP id j5so2936271qaq.0 for ; Thu, 06 Mar 2014 10:09:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=KmPTyr6adu02o9KoM6hgOCYc69InWjfcPq6QbHsDVHg=; b=O4aoCxTd6X0sv7s2oe2n9Dl/Mc6uKd2fJW6Tblb2WmTMw1sjHq53mXTVphnOauqgXZ dSK8S7TmAYsbWVeHsT8fYkdqnTIVyG2C6cJ9cnWLEvzPpcC7Db5J4wKhKn6kNR1tUk/G dWrUkuGdFX9IfUZZOL2TxP1N9gCBSkSRao0KBMi6EImQqo/5XLL+XnB09f0wr4JUeT1H uME+XqrCZWYJ6yE7kl9CYACbnoKukg1zWyzqD5qesiP1JbiWQ4lZCyim62jyQfWD+fDx nSAmj/60BwE8+3phvFHjusuR3EzyzCB003E2NJURoj1e7rBcE/QIFtHjmUF4AEEJZG5c tPxg== X-Gm-Message-State: ALoCoQlH1rvBZMwAAKxrynCgRm7g82smb25c/3UcFKeUK9Qo6sreuprFuUb6fLpc9dQWXJyf8Vt1 X-Received: by 10.224.21.129 with SMTP id j1mr15849120qab.13.1394128946640; Thu, 06 Mar 2014 10:02:26 -0800 (PST) MIME-Version: 1.0 Sender: jmmv@meroh.net Received: by 10.96.83.102 with HTTP; Thu, 6 Mar 2014 10:02:06 -0800 (PST) X-Originating-IP: [2620:0:1003:1021:5c49:13a2:f7c6:9920] In-Reply-To: References: <20140305085806.GA70478@x2.osted.lan> <20140306112322.GA10664@x2.osted.lan> From: Julio Merino Date: Thu, 6 Mar 2014 13:02:06 -0500 X-Google-Sender-Auth: TOYQKy9TOCN8earyKHft3A3Llsc Message-ID: Subject: Re: Test scenario for sysctl kern.maxfiles To: Alan Somers Content-Type: text/plain; charset=ISO-8859-1 Cc: "freebsd-testing@freebsd.org" , Peter Holm X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Mar 2014 18:09:33 -0000 On Thu, Mar 6, 2014 at 12:45 PM, Alan Somers wrote: > I suggest the more specific name "allow_sysctl_side_effects". As I > continue to add tests, config variables like this will become more > important. In particular, I have some tests that create and destroy > zpools, some that can cause panics, some that load modules, etc. > Before I can upstream all of them, we'll need to agree on a consistent > set of config variables that control test case execution. I haven't > put much thought into it yet. Sure; more granularity++. I haven't put any thought on this though so please propose something :) Whatever we decide, 1) these variables need to be documented in tests(7), 2) a ready-to-enable template in ports/devel/kyua-cli/files/kyua.conf.in about them would be beneficial and 3) src/projects/jmmv/autotest/ should switch these on. > How does NetBSD handle tests that have > potentially harmful side effects? They don't AFAIK. The thing is that not that many tests have side-effects because the majority of kernel-level tests use rump to avoid this problem and be more reliable/deterministic. The few that have side-effects have ad-hoc cleanup routines.