From owner-cvs-src@FreeBSD.ORG Tue Nov 22 18:04:11 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 84C9416A41F; Tue, 22 Nov 2005 18:04:11 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5E51643D55; Tue, 22 Nov 2005 18:04:10 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.5b3) with ESMTP id 2433360 for multiple; Tue, 22 Nov 2005 13:04:16 -0500 Received: from localhost (john@localhost [127.0.0.1]) by server.baldwin.cx (8.13.1/8.13.1) with ESMTP id jAMI3xdL078433; Tue, 22 Nov 2005 13:03:59 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Ruslan Ermilov Date: Tue, 22 Nov 2005 10:50:39 -0500 User-Agent: KMail/1.8.2 References: <200511212201.jALM1Ggp080941@repoman.freebsd.org> <20051122143721.GE65080@ip.net.ua> In-Reply-To: <20051122143721.GE65080@ip.net.ua> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200511221050.41796.jhb@freebsd.org> X-Spam-Status: No, score=-2.8 required=4.2 tests=ALL_TRUSTED autolearn=failed version=3.0.2 X-Spam-Checker-Version: SpamAssassin 3.0.2 (2004-11-16) on server.baldwin.cx X-Server: High Performance Mail Server - http://surgemail.com r=1653887525 Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/acpica acpi_pci_link.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Nov 2005 18:04:11 -0000 On Tuesday 22 November 2005 09:37 am, Ruslan Ermilov wrote: > On Mon, Nov 21, 2005 at 10:01:16PM +0000, John Baldwin wrote: > > jhb 2005-11-21 22:01:16 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/acpica acpi_pci_link.c > > Log: > > Fix the code to look up the BIOS IRQ for a given link device by reading > > the IRQ set by the BIOS in existing devices to actually get the correct > > bus number of the child PCI bus. I was not reading the bus number from > > the bridge device correctly. The __BUS_ACCESSOR() macros (from which > > pcib_get_bus() is built) assume that the passed in argument is a child > > device. However, at the time I'm reading the bus there is no child > > device yet, so I was passing in the pcib device as the child device. > > The parent of the pcib device probably returned an error in the case of > > a host bridge, thus resulting in random stack garbage for the bus > > number. For PCI-PCI bridges, the bus number being used was actually the > > subvendor of the PCI-PCI bridge device itself. > > > > MFC after: 1 week > > > > Revision Changes Path > > 1.49 +15 -3 src/sys/dev/acpica/acpi_pci_link.c > > Looks like I no longer need these hw.pci.link.LNK[A-D].irq=11 > in /boot/loader.conf after this change. Woah, that's a good fix then. This was on a T43? -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org