From owner-svn-src-all@FreeBSD.ORG Sun Jun 14 19:36:16 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E48B91065670; Sun, 14 Jun 2009 19:36:16 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from mx0.deglitch.com (backbone.deglitch.com [IPv6:2001:16d8:fffb:4::abba]) by mx1.freebsd.org (Postfix) with ESMTP id 914E18FC12; Sun, 14 Jun 2009 19:36:16 +0000 (UTC) (envelope-from stas@FreeBSD.org) Received: from orion.SpringDaemons.com (unknown [77.232.3.143]) by mx0.deglitch.com (Postfix) with ESMTPA id 6ABD28FC2E; Sun, 14 Jun 2009 23:36:14 +0400 (MSD) Received: from orion (localhost [127.0.0.1]) by orion.SpringDaemons.com (Postfix) with SMTP id A05C939C4B; Sun, 14 Jun 2009 23:36:11 +0400 (MSD) Date: Sun, 14 Jun 2009 23:36:07 +0400 From: Stanislav Sedov To: Ivan Voras Message-Id: <20090614233607.8db3c945.stas@FreeBSD.org> In-Reply-To: <200906130027.n5D0R3CU097629@svn.freebsd.org> References: <200906130027.n5D0R3CU097629@svn.freebsd.org> Organization: The FreeBSD Project X-Mailer: carrier-pigeon Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA1"; boundary="Signature=_Sun__14_Jun_2009_23_36_07_+0400_Tn1szYaupzDOFSji" Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r194092 - in head: sbin/geom/class/label sys/conf sys/geom/label X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 14 Jun 2009 19:36:17 -0000 --Signature=_Sun__14_Jun_2009_23_36_07_+0400_Tn1szYaupzDOFSji Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! There're some style errors in the file. See below. On Sat, 13 Jun 2009 00:27:03 +0000 (UTC) Ivan Voras mentioned: > + > +#define PART_CLASS_NAME "PART" > +#define SCHEME_NAME "GPT" > + > +#define G_LABEL_GPT_VOLUME_DIR "gpt" ^^^ > +#define G_LABEL_GPT_ID_DIR "gptid" ^^^ These shoule be tabs, not spaces as above. > + > +/* shamelessly stolen from g_part_gpt.c */ > +static void > +sbuf_nprintf_utf16(struct sbuf *sb, uint16_t *str, size_t len) > +{ <...> > + } > +} Why not put this function into the separate file, or turn it into inline? This way you'll avoid code duplication. > + /* > + * create sbuf with biggest possible size > + * we need max. 4 bytes for every 2-byte utf16 char > + */ Most of comments in geom code start with a capital and end up with a dot. This one doesn't follow this rule. There're also other places. --=20 Stanislav Sedov ST4096-RIPE --Signature=_Sun__14_Jun_2009_23_36_07_+0400_Tn1szYaupzDOFSji Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- iQIcBAEBAgAGBQJKNVErAAoJEKN82nOYvCd03vkQALNXCNaoOroqP2tRZWPW5aB0 goETQ44ZmI//qrf0v8cmgvIWpArqX6ru8EKnQ+CNyqOPoD9oCEb9gokG8b/xcpEO amZjTOJItW0v4xmoOZrI9AfzGDj4b+aF3Fwkpr/m+/VnBQsUg6ouxRazD21p4f1B QaXoQwWnRvISX7qhuzsBMME2LVuk3xs/ntjIl8wQl/jyHebN6Ho8LxQUMzYHGXfL WcCFL9woDEB38Mp4dPIcJahX0ff5H/AdT/lL0sRwamO7JxyKmnPZaWMLgx+im4gY hvReA7ED88lj+hrFrTUIwC3QMfxmC9LSYq2r1A8c1V3j+u6NnNq4b5YyW88fH2Al +ixGuq1HMJ5XNJXDR6s1Z6G5Rh4BueWneIFttGW9CmQYhPcE20RK/w3Bapi1TGO2 LxO1LYMZ86FO2vJiA8kUK1sH0IduQgFW1w1lrukSH7pm/JpU+36IS4xUGvyqMCt0 ZPMqDElr+V2KsvTJIdPAWO6HFeXFMnMUnq8g93YQ2AslRQLeM5Bbj3tt9NZ8QGv0 CSYLKUBEnQZyBnnjJ+Dis6iPpIOyNyKqMZBCn8qxK9b8mZTich7QYbQOvKxfsFZy 2s6KY5oBii2xpJG+qLmiWyqysgZ80SidInpaAxKvKPMPiMLx+WURDF6X6A3unC/9 XcVvwoMYHJTbboz5/ovd =ywzK -----END PGP SIGNATURE----- --Signature=_Sun__14_Jun_2009_23_36_07_+0400_Tn1szYaupzDOFSji--