From nobody Sat Apr 18 01:12:51 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fyDJM6cC4z6ZTmX for ; Sat, 18 Apr 2026 01:12:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fyDJM2Ds9z3nS7 for ; Sat, 18 Apr 2026 01:12:51 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776474771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wMj29yvgF6S1vy1nVz+NrryWUbDaBW7EDe+kmBautHQ=; b=m99wZ/4sYGpsYhqBXC9Pw+Q/fTMPNrCvmaXzQC0bBsTCEajFNNViJc2Se0hqDT18Qu9zog 24qUXgLmeyfFSv13qIFuy8z100saCvXGjUV4pdoOsWlRX27CL8ypxEuOmYwD6Td6kjuxRN SI8D/Ckf20fj+6+QbVDz9LjP8zaYn9PlUlT2Y/iXTUtv/BKNzQwQ8OvLUzWkNLmdnyAuBR 1qEDipEuOSVX7GI3DR2sWw5VBPJLTq9T5pVF7Ecj6gxEfVQ4E3KlJFGlLj5j+5HHjN0su9 ZRa8t65DNGiYtcLq8gmvadU6oN4eYmccWHHrsytox/98JOQ0cFBI/bqv1p34qA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1776474771; a=rsa-sha256; cv=none; b=m3uxq9NPnmSURWtobr8QAIrhQJYNYIfO2E8u/r7ALrjnMyofRox2ZdgCLlUcZBN4H/YpXb nQeIOrWlX201LewZ9MXmhRskRU+5aaEXwfSpJUlOfYSc+C8hzc8/McRxgb+66MxMCpGcAe qTsPHvylVivXicjexlnnXvF9dJHBYofZt1gOCQeE2pfpJkp0d1PNIpmB6j0WQQCKQAje+3 gXuySFQhjyhE4IyoxnljrzKnMZes/MV3HtAE1CoQyNOx0+x+ERbGK9FMCu7690fNiBXTVV e3AmbFL5baLU+XzIasrvLTDRH7mStxLdLl3PA6u2lTjqYQogd1Lkl5PiyXjZxw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1776474771; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wMj29yvgF6S1vy1nVz+NrryWUbDaBW7EDe+kmBautHQ=; b=eTiQBuN1bOKiPec8TpQAkHgtd/606yfj7J8LLjMA/eiVnvpq5vS/qf7bB8cZt124uj+zD8 MXm6OrGzgXPPIa8YFCKSN5uUvSL9dLpmiT7Yyre6o8Vq75qY/rSEZrrwXmQ7psJUiDh18J 4XuohlHtfLMpJWWfQxxdwpTgbhfZfrMzs8pzBLxvPsflOLTDFKryCRBzZ7aBUs2dwY9DSv Yp83oSovCo0VI8sMNIPilsKRFiWhXmYLpTRQshyR8TPh4gxq4LON2zRBEPEe88I3W7Wf0x xHpT6zUZBo1ZQxZ1XMiSenShc7QpInII01Tqn50tJXru5CpciL8zD4xCezsIhg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4fyDJM1l61z28H for ; Sat, 18 Apr 2026 01:12:51 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 468b8 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Sat, 18 Apr 2026 01:12:51 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Bjoern A. Zeeb Subject: git: 99bbfb77e3c3 - main - rtw89: add a warn about beacon_int or dtim_period being 0 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 99bbfb77e3c395805fe0a7f19006c5c29136f9fc Auto-Submitted: auto-generated Date: Sat, 18 Apr 2026 01:12:51 +0000 Message-Id: <69e2da93.468b8.38ce4040@gitrepo.freebsd.org> The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=99bbfb77e3c395805fe0a7f19006c5c29136f9fc commit 99bbfb77e3c395805fe0a7f19006c5c29136f9fc Author: Bjoern A. Zeeb AuthorDate: 2026-04-17 02:40:03 +0000 Commit: Bjoern A. Zeeb CommitDate: 2026-04-18 01:12:11 +0000 rtw89: add a warn about beacon_int or dtim_period being 0 While after the changes to LinuxKPI 802.11 we should never be assoc and not have dtim_period set, we have seen before that this could happen. Add a WARN as that will help debugging the following DIV 0. Sponsored by: The FreeBSD Foundation MFC after: 3 days --- sys/contrib/dev/rtw89/core.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/contrib/dev/rtw89/core.c b/sys/contrib/dev/rtw89/core.c index aeaf1c8f80c5..1dee73a62f98 100644 --- a/sys/contrib/dev/rtw89/core.c +++ b/sys/contrib/dev/rtw89/core.c @@ -2838,6 +2838,10 @@ static void rtw89_core_bcn_track_assoc(struct rtw89_dev *rtwdev, dtim = bss_conf->dtim_period; rcu_read_unlock(); +#if defined(__FreeBSD__) + WARN(beacon_int == 0 || dtim == 0, "period %u / beacon_int %u / dtim %u\n", + period, beacon_int, dtim); +#endif beacons_in_period = period / beacon_int / dtim; bcn_intvl_us = ieee80211_tu_to_usec(beacon_int);