Date: Fri, 12 Jun 2009 18:24:04 +0000 From: Navdeep Parhar <np@FreeBSD.org> To: "Bjoern A. Zeeb" <bz@FreeBSD.org> Cc: Pyun YongHyeon <pyunyh@gmail.com>, FreeBSD net mailing list <freebsd-net@freebsd.org>, "George V. Neville-Neil" <gnn@freebsd.org>, Michael Tuexen <tuexen@freebsd.org>, Andrew Thompson <thompsa@freebsd.org>, Jack F Vogel <jfv@freebsd.org>, Andrew Gallatin <gallatin@freebsd.org>, Pyun YongHyeon <yongari@freebsd.org> Subject: Re: Ethernet NIC drivers depending unconditionally on INET Message-ID: <20090612182404.GA20035@hub.freebsd.org> In-Reply-To: <20090612173728.B22887@maildrop.int.zabbadoz.net> References: <20090611184555.J22887@maildrop.int.zabbadoz.net> <20090612013406.GB72855@michelle.cdnetworks.co.kr> <20090612100900.M22887@maildrop.int.zabbadoz.net> <20090612170703.GA994@hub.freebsd.org> <20090612173728.B22887@maildrop.int.zabbadoz.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Jun 12, 2009 at 05:38:46PM +0000, Bjoern A. Zeeb wrote: > On Fri, 12 Jun 2009, Navdeep Parhar wrote: > > >On Fri, Jun 12, 2009 at 10:56:31AM +0000, Bjoern A. Zeeb wrote: > >>On Fri, 12 Jun 2009, Pyun YongHyeon wrote: > >> > >>Hi, > >> > >>>Yeah, there are no checksum offloading support for IPv6 under > >>>FreeBSD so there are no cases the frames are IPv6 when > >>>CSUM_IP/CSUM_TCP/CSUM_UDP/CSUM_TSO was set. > >> > >>The thing that scared me was sys/netinet/tcp_subr.c:tcp_maxmtu6(). > >> > >>What I had missed was the CSUM_TSO6 (the 6 at the end) part. > >>grepping through the tree I am even wondering a lot more now when I > >>see what cxgb(4) is doing with that;) > > > >I can't find a CSUM_TSO6 in head, did you mean IFCAP_TSO6? > > yes I did. > > >cxgb(4) > >will not let you enable IFCAP_TSO6 on the interface. It has always > >been disallowed as far as I can tell. > > Yes, you have it in the logic bu you define it to 0;) > #define IFCAP_TSO6 0x0 Not quite. TSO_SUPPORTED is defined and so cxgb(4) picks up the right values of IFCAP_TSO4 and IFCAP_TSO6. It's just that IFCAP_TSO6 is not in the enabled-by-default capabilities (CXGB_CAP_ENABLE), and cxgb_ioctl will not let you enable IFCAP_TSO6. cxgb's silicon supports TSO+IPv6, so I'm not sure why things are the way they are. If the stack's tso6 works, then this is a bug in cxgb. Regards, Navdeep > > /bz > > -- > Bjoern A. Zeeb The greatest risk is not taking one.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090612182404.GA20035>