From owner-cvs-src@FreeBSD.ORG Wed Dec 3 10:46:44 2003 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7566016A4CF for ; Wed, 3 Dec 2003 10:46:44 -0800 (PST) Received: from mail1.speakeasy.net (mail1.speakeasy.net [216.254.0.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id 80C0843FEC for ; Wed, 3 Dec 2003 10:46:37 -0800 (PST) (envelope-from jmg@hydrogen.funkthat.com) Received: (qmail 27199 invoked from network); 3 Dec 2003 18:46:36 -0000 Received: from unknown (HELO hydrogen.funkthat.com) ([69.17.45.168]) (envelope-sender ) by mail1.speakeasy.net (qmail-ldap-1.03) with SMTP for ; 3 Dec 2003 18:46:36 -0000 Received: from hydrogen.funkthat.com (hktgbs@localhost.funkthat.com [127.0.0.1])hB3IkZgP066986; Wed, 3 Dec 2003 10:46:36 -0800 (PST) (envelope-from jmg@hydrogen.funkthat.com) Received: (from jmg@localhost) by hydrogen.funkthat.com (8.12.10/8.12.10/Submit) id hB3IkZmJ066985; Wed, 3 Dec 2003 10:46:35 -0800 (PST) Date: Wed, 3 Dec 2003 10:46:35 -0800 From: John-Mark Gurney To: Ian Dowse Message-ID: <20031203184635.GC54398@funkthat.com> References: <200311250223.hAP2NTua051542@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200311250223.hAP2NTua051542@repoman.freebsd.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 4.2-RELEASE i386 X-PGP-Fingerprint: B7 EC EF F8 AE ED A7 31 96 7A 22 B3 D8 56 36 F4 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: green@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/usb ohci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: John-Mark Gurney List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Dec 2003 18:46:44 -0000 Ian Dowse wrote this message on Mon, Nov 24, 2003 at 18:23 -0800: > iedowse 2003/11/24 18:23:29 PST > > FreeBSD src repository > > Modified files: > sys/dev/usb ohci.c > Log: > Write the correct value to `td_be' for the second and further > transfer descriptors when a large request needs to be split into > more than one 8k chunk. The bug was that the calculation did not > take into account the offset of the chunk within the overall request. > This is reported to fix crashes and data corruption on ohci > controllers. > > Submitted by: green > Approved by: re Thanks for tracking this down for me. I wonder how/why it worked on my system with such an obvious bug!! -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."