From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Jan 18 16:30:09 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3431B1065692 for ; Mon, 18 Jan 2010 16:30:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id EA23F8FC19 for ; Mon, 18 Jan 2010 16:30:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id o0IGU8sT026811 for ; Mon, 18 Jan 2010 16:30:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id o0IGU8ax026809; Mon, 18 Jan 2010 16:30:08 GMT (envelope-from gnats) Resent-Date: Mon, 18 Jan 2010 16:30:08 GMT Resent-Message-Id: <201001181630.o0IGU8ax026809@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Greg Larkin Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BF671106566C for ; Mon, 18 Jan 2010 16:29:35 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id ADE3A8FC13 for ; Mon, 18 Jan 2010 16:29:35 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id o0IGTZum076375 for ; Mon, 18 Jan 2010 16:29:35 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id o0IGTZol076374; Mon, 18 Jan 2010 16:29:35 GMT (envelope-from nobody) Message-Id: <201001181629.o0IGTZol076374@www.freebsd.org> Date: Mon, 18 Jan 2010 16:29:35 GMT From: Greg Larkin To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/142939: [PATCH] sysutils/xfce4-netload-plugin: Adjust OSVERSION in check for BROKEN X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jan 2010 16:30:09 -0000 >Number: 142939 >Category: ports >Synopsis: [PATCH] sysutils/xfce4-netload-plugin: Adjust OSVERSION in check for BROKEN >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Mon Jan 18 16:30:08 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Greg Larkin >Release: 7.0-RELEASE >Organization: The FreeBSD Project >Environment: FreeBSD fbsd70.entropy.prv 7.0-RELEASE FreeBSD 7.0-RELEASE #0: Sun Feb 24 19:59: 52 UTC 2008 root@logan.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: sysutils/xfce4-netload-plugin was marked BROKEN on 8.0 (OSVERSION >= 800000) because of a compile error resulting from a missing net/if_ppp.h include file. net/if_ppp.h was removed for OSVERSION >= 800045, so adjust the check in the Makefile with that version. Further discussion of the removal of if_ppp(4) can be found here: http://www.mail-archive.com/svn-src-all@freebsd.org/msg07293.html A better solution would be to port xfce4-netload-plugin to use ppp(8) instead of if_ppp(4), if possible. >How-To-Repeat: >Fix: See attached patch Patch attached with submission follows: Index: sysutils/xfce4-netload-plugin/Makefile =================================================================== RCS file: /home/pcvs/ports/sysutils/xfce4-netload-plugin/Makefile,v retrieving revision 1.30 diff -u -r1.30 Makefile --- sysutils/xfce4-netload-plugin/Makefile 10 Jan 2010 09:56:21 -0000 1.30 +++ sysutils/xfce4-netload-plugin/Makefile 18 Jan 2010 16:22:31 -0000 @@ -24,7 +24,7 @@ .include -.if ${OSVERSION} >= 800000 +.if ${OSVERSION} >= 800045 BROKEN= does not compile: error: net/if_ppp.h: No such file or directory .endif >Release-Note: >Audit-Trail: >Unformatted: