Date: Sat, 17 Jul 2004 21:10:24 GMT From: Thierry Thomas <thierry@FreeBSD.org> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/68052: [NEW PORT] graphics/jumpgis: A GUI based application for viewing and processing spatial data Message-ID: <200407172110.i6HLAOnM097618@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/68052; it has been noted by GNATS.
From: Thierry Thomas <thierry@FreeBSD.org>
To: FreeBSD-gnats-submit@freebsd.org
Cc:
Subject: Re: ports/68052: [NEW PORT] graphics/jumpgis: A GUI based application for viewing and processing spatial data
Date: Sat, 17 Jul 2004 23:03:55 +0200
[Follow-up already sent, but lost in cyberspace]
Le Ven 9 jul 04 à 5:16:06 +0200, Sam Lawrance <boris@brooknet.com.au>
écrivait :
> Apologies for slow response, was on a holiday :)
And I have misfiled your mail...
> > For example do-extract: seems unnecessary
>
> I made the do-extract the way it is because the distfile isn't
> structured the usual way - it doesn't extract into a single
> subdirectory. eg:
>
> sam@dirk distfiles$ unzip -t jump-1.1.1.zip
> Archive: jump-1.1.1.zip
> testing: bin/ OK
> testing: doc/ OK
> testing: lib/ OK
> testing: lib/ext/ OK
> testing: bin/JUMPWorkbench-mac.sh OK
> testing: bin/JUMPWorkbench-unix.sh OK
> and so on. So the do-extract creates WRKSRC on top of WRKDIR (usually
> WRKSRC is created by extracting the archive) and then extracts in to it.
>
> If I can do it a better way drop a hint.
The following patch should do what you want:
--- jumpgis.diff begins here ---
diff -urN graphics/jumpgis.orig/Makefile graphics/jumpgis/Makefile
--- graphics/jumpgis.orig/Makefile Sat Jul 17 11:12:45 2004
+++ graphics/jumpgis/Makefile Sat Jul 17 11:29:02 2004
@@ -18,13 +18,18 @@
COMMENT= A GUI based application for viewing and processing spatial data
WRKSRC= ${WRKDIR}/jump
+EXTRACT_AFTER_ARGS= -d ${WRKSRC}
TARGET_DIR= ${PREFIX}/${PORTNAME}
+
USE_JAVA= 1.4+
USE_ZIP= yes
NO_BUILD= yes
WANT_GNOME= yes
PORTDOCS= *
+USE_REINPLACE= yes
+REINPLACE_ARGS= -i ""
+
.include <bsd.port.pre.mk>
.if ${HAVE_GNOME:Mgnomelibs}!=""
@@ -35,34 +40,30 @@
"@cwd %%PREFIX%%"
.endif
-do-extract:
- @${MKDIR} ${WRKDIR}
- @${MKDIR} ${WRKSRC}
- @${UNZIP_CMD} -q ${DISTDIR}/jump-1.1.1.zip -d ${WRKSRC}
-
-do-patch:
- @${REINPLACE_CMD} -i "" -e "s,#!sh,#!/bin/sh,g" ${WRKSRC}/bin/JUMPWorkbench-unix.sh
- @${REINPLACE_CMD} -i "" -e "s,^set LIB=../lib,LIB=${TARGET_DIR}/lib,g" ${WRKSRC}/bin/JUMPWorkbench-unix.sh
- @${REINPLACE_CMD} -i "" -e "s,workbench-properties.xml,~/.jump-workbench-properties.xml,g" ${WRKSRC}/bin/JUMPWorkbench-unix.sh
+post-patch:
+ @${REINPLACE_CMD} -e "s,#!sh,#!/bin/sh,g" \
+ -e "s,^set LIB=../lib,LIB=${TARGET_DIR}/lib,g" \
+ -e "s,workbench-properties.xml,~/.jump-workbench-properties.xml,g" \
+ ${WRKSRC}/bin/JUMPWorkbench-unix.sh
do-install:
@${ECHO_CMD} "---> Installing JAR files"
${MKDIR} ${TARGET_DIR}/lib
${INSTALL_DATA} ${WRKSRC}/lib/*.jar ${TARGET_DIR}/lib
${INSTALL_DATA} -d ${TARGET_DIR}/lib/ext
- @${ECHO} "Installing startup script"
+ @${ECHO_MSG} "Installing startup script"
${INSTALL_SCRIPT} ${WRKSRC}/bin/JUMPWorkbench-unix.sh ${PREFIX}/bin/jumpgis
.if !defined(NOPORTDOCS)
- @${ECHO} "---> Installing documentation"
+ @${ECHO_MSG} "---> Installing documentation"
${MKDIR} ${DOCSDIR}
${CP} -r ${WRKSRC}/doc/* ${DOCSDIR}
.else
- @${ECHO} "---> Skipping documentation"
+ @${ECHO_MSG} "---> Skipping documentation"
.endif
.if ${HAVE_GNOME:Mgnomelibs}!=""
- @${ECHO} "---> Installing GNOME application links"
+ @${ECHO_MSG} "---> Installing GNOME application links"
${INSTALL_DATA} ${DISTDIR}/jump.desktop ${X11BASE}/share/gnome/applications/
${INSTALL_DATA} ${DISTDIR}/jump.png ${X11BASE}/share/gnome/pixmaps/
.endif
--- jumpgis.diff ends here ---
However, the files listed as PATCHFILES don't contain patches: you
should use DISTFILES and EXTRACT_ONLY.
Regards,
--
Th. Thomas.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200407172110.i6HLAOnM097618>