Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 3 Jun 2015 14:42:43 -0400
From:      Tom Pusateri <pusateri@bangj.com>
To:        Jan Beich <jbeich@vfemail.net>
Cc:        freebsd-ports@freebsd.org
Subject:   Re: Help with new port with multiple downloaded files from github
Message-ID:  <CF92424E-C5E3-4509-94BB-33CBD1805F98@bangj.com>
In-Reply-To: <eglt-uscd-wny@FreeBSD.org>
References:  <556E83CE.2020209@bangj.com> <eglt-uscd-wny@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--Apple-Mail=_9FE074A0-B7BA-4541-9338-24DB6A988DFF
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8


> On Jun 3, 2015, at 4:08 AM, Jan Beich <jbeich@vfemail.net> wrote:
>=20
> Why are you trying to replicate www/chromium logic instead of making
> a slave of it?

I didn=E2=80=99t know about slave ports. I don=E2=80=99t see much about =
them in the Porter=E2=80=99s handbook. Any docs on them? I=E2=80=99ll =
gladly do this whatever is the best way.

>=20
> Tom Pusateri <pusateri@bangj.com> writes:
>=20
>> PORTVERSION=3D    43.0.2357.65
>> DISTVERSIONPREFIX=3D      v
>> DISTVERSIONSUFFIX=3D      1
>=20
> According to the project's releases page 43.0.2357.65 ends in either
> -atom or -atom-1, not just 1.
>=20

Ok, I changed that.

>> root@dark:/home/pusateri/ports/www/libchromiumcontent # make
>> =3D=3D=3D>   libchromiumcontent-43.0.2357.65 depends on file:
>> /usr/local/sbin/pkg - found
>> =
_MASTER_SITES_freebsd-chromium=3Dhttps://codeload.github.com/gliaskos/free=
bsd-chromium/tar.gz/418e996e3a?dummy=3D/:
>> not found
>> *** Error code 127
> [...]
>> USE_GITHUB=3D    yes
>> GH_ACCOUNT=3D    atom:libchromiumcontent \
>>                             gliaskos:freebsd-chromium
>=20
> MASTER_SITE_${group} is implemented via sh(1) that supports limited =
set
> of characters of in variable names of which - (hyphen) isn't one. So,
> try replacing :freebsd-chromium with :freebsd_chromium.

Yes, that fixes my download problem.

>> GH_PROJECT=3D    libchromiumcontent:libchromiumcontent \
>>                           freebsd-chromium:freebsd-chromium
>> GH_TAGNAME=3D
>> =
${DISTVERSIONPREFIX}${PORTVERSION}-${GH_ACCOUNT}-${DISTVERSIONSUFFIX}:libc=
hromiumcontent
>> \
>>                           418e996e3a:freebsd-chromium
>=20
> No need to put PORTNAME-derived GH_PROJECT under a separate group as
> it'd add a duplicate unless USE_GITHUB=3Dnodefault. Try instead
>=20
>  GH_ACCOUNT=3D    atom gliaskos:freebsd_chromium
>  GH_PROJECT=3D    freebsd-chromium:freebsd_chromium
>  GH_TAGNAME=3D    418e996e3a:freebsd_chromium

Yes, that simplifies things.

>  $ make fetch-urlall-list MASTER_SITE_BACKUP=3D
>  =
https://codeload.github.com/atom/libchromiumcontent/tar.gz/v43.0.2357.65-a=
tom-1?dummy=3D/atom-libchromiumcontent-v43.0.2357.65-atom-1_GH0.tar.gz
>  =
https://codeload.github.com/gliaskos/freebsd-chromium/tar.gz/418e996e3a?du=
mmy=3D/gliaskos-freebsd-chromium-418e996e3a_GH0.tar.gz
>=20
> Hmm, freebsd-chromium-418e996e3a tracks 42.0.2311.135. I don't think
> mixing patches for different *major* chromium versions is going to =
work.

Right. I was grabbing tags from multiple sources and not paying =
attention to that yet. Fixed.

Thanks for the help. This works now and the versions match.

PORTNAME=3D       libchromiumcontent
PORTVERSION=3D    43.0.2357.65
DISTVERSIONPREFIX=3D      v
DISTVERSIONSUFFIX=3D      -atom-1
CATEGORIES=3D     www

MAINTAINER=3D     pusateri@bangj.com
COMMENT=3D        Shared library build of Chromium's Content module

USE_GITHUB=3D     yes
GH_ACCOUNT=3D     atom gliaskos:freebsd_chromium
GH_PROJECT=3D     freebsd-chromium:freebsd_chromium
GH_TAGNAME=3D     b715e82:freebsd_chromium

Thanks!
Tom



--Apple-Mail=_9FE074A0-B7BA-4541-9338-24DB6A988DFF
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP using GPGMail

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQEcBAEBCAAGBQJVb0qkAAoJEPk0GMVmUuYML9sH/iz+BDqwN9UuqW56It1+0Kgd
xPHR863lnhWPJ9dF3QKupXfPUg3/QOF83baocB/lFaFTA6VaW+rguieP5fUSDc1T
DOx4Rtl+Rqsss09/Pu5yEioao5yZhBIXs3/DMhPEQamVYjHc8d5QRYictUq31Es9
M8EJOhbhTc5UIzA0M8brit+Ag4haOYlABJmENeHdVIejfRVK2yHxekVtgDe9GRVQ
rB7DEXOPknUKa3vn6n+OfY3f2bRzOx8zZbSwwNxx8GD1wP6MEU2OsBBf/CJJKHVp
ayl22NWZbsSfAeljxzW5yx09SyEb4Xkz269dwETo1GBolMGCUaViVTyZUtz8Jyk=
=rqFr
-----END PGP SIGNATURE-----

--Apple-Mail=_9FE074A0-B7BA-4541-9338-24DB6A988DFF--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CF92424E-C5E3-4509-94BB-33CBD1805F98>