From owner-freebsd-acpi@FreeBSD.ORG  Fri Dec 14 22:08:31 2012
Return-Path: <owner-freebsd-acpi@FreeBSD.ORG>
Delivered-To: freebsd-acpi@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
 by hub.freebsd.org (Postfix) with ESMTP id 770531EA8;
 Fri, 14 Dec 2012 22:08:31 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from bigwig.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net
 [IPv6:2001:470:1f10:75::2])
 by mx1.freebsd.org (Postfix) with ESMTP id 487BE8FC12;
 Fri, 14 Dec 2012 22:08:31 +0000 (UTC)
Received: from pakbsde14.localnet (unknown [38.105.238.108])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id A5107B948;
 Fri, 14 Dec 2012 17:08:30 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: sbruno@freebsd.org
Subject: Re: oh right, this one ...
Date: Fri, 14 Dec 2012 15:31:58 -0500
User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p22; KDE/4.5.5; amd64; ; )
References: <1355249630.2526.1.camel@powernoodle.corp.yahoo.com>
 <1355251688.2526.5.camel@powernoodle.corp.yahoo.com>
In-Reply-To: <1355251688.2526.5.camel@powernoodle.corp.yahoo.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201212141531.59181.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Fri, 14 Dec 2012 17:08:30 -0500 (EST)
Cc: freebsd-acpi@freebsd.org
X-BeenThere: freebsd-acpi@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: ACPI and power management development <freebsd-acpi.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-acpi>,
 <mailto:freebsd-acpi-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-acpi>
List-Post: <mailto:freebsd-acpi@freebsd.org>
List-Help: <mailto:freebsd-acpi-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-acpi>,
 <mailto:freebsd-acpi-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Dec 2012 22:08:31 -0000

On Tuesday, December 11, 2012 1:48:08 pm Sean Bruno wrote:
> On Tue, 2012-12-11 at 10:13 -0800, Sean Bruno wrote:
> > Finally got around to returning the Dell R620 series BIOS update that
> > breaks badly on FreeBSD.  I suspect that there is an ACPI update going
> > on here that I need to figure out for -current.  I'm going to disable
> > the pci bus that fails to attach via device hints and get an acpidump in
> > a bit.
> 
> acpidump --> http://people.freebsd.org/~sbruno/r620_acpi.txt
> pciconf -lvcb --> http://people.freebsd.org/~sbruno/r620_pciconf.txt
> 
> Problematic pci bus attach is on pcib6
> 
> pcib6: <ACPI PCI-PCI bridge> at device 28.0 on pci0
> pcib6:   domain            0
> pcib6:   secondary bus     6
> pcib6:   subordinate bus   6
> pcib6:   no prefetched decode
> device_attach: pcib6 attach returned 6
> pcib6: <ACPI PCI-PCI bridge> irq 19 at device 28.7 on pci0
> panic: Bad tailq NEXT(0xffffffff814f3318->tqh_last) != NULL
> 
> 
> A couple of comments here.  It sure *looks* like the failure to attach
> doesn't clean up after itself, which then leads to a *reuse* of pcib6
> data elements for pcib7!
> 
> 1.  we fail to attach to pcib6
> 2.  we don't clean up properly on a failure to attach
> 3.  we try to reuse the data structure that failed for the next pcib
> device.

Yes, it is known to not clean up after itself.  Fixing that isn't entirely 
trivial.  Disable pcib6 instead of trying to disable pci6.

-- 
John Baldwin