From owner-freebsd-ports-bugs@FreeBSD.ORG Sun May 30 17:30:23 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EF43416A4CE for ; Sun, 30 May 2004 17:30:22 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id D4BF143D54 for ; Sun, 30 May 2004 17:30:22 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i4V0UMSt002045 for ; Sun, 30 May 2004 17:30:22 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i4V0UMKY002038; Sun, 30 May 2004 17:30:22 -0700 (PDT) (envelope-from gnats) Resent-Date: Sun, 30 May 2004 17:30:22 -0700 (PDT) Resent-Message-Id: <200405310030.i4V0UMKY002038@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Taoka Fumiyoshi Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4D7BF16A4CE for ; Sun, 30 May 2004 17:24:36 -0700 (PDT) Received: from prime.quad.dyndns.org (12.57.138.210.xn.2iij.net [210.138.57.12]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9CE8843D2F for ; Sun, 30 May 2004 17:24:35 -0700 (PDT) (envelope-from fmysh@quad.dyndns.org) Received: from localhost (localhost [127.0.0.1]) by prime.quad.dyndns.org (Postfix) with ESMTP id 743B2F233E; Mon, 31 May 2004 09:24:34 +0900 (JST) Received: from prime.quad.dyndns.org ([127.0.0.1]) by localhost (prime.quad.dyndns.org [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 95569-09; Mon, 31 May 2004 09:24:33 +0900 (JST) Received: by prime.quad.dyndns.org (Postfix, from userid 1001) id 1DB58F2303; Mon, 31 May 2004 09:24:33 +0900 (JST) Message-Id: <20040531002433.1DB58F2303@prime.quad.dyndns.org> Date: Mon, 31 May 2004 09:24:33 +0900 (JST) From: Taoka Fumiyoshi To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/67403: games/kdegames3 installs some files with invalid uid and gid X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Taoka Fumiyoshi List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 May 2004 00:30:23 -0000 >Number: 67403 >Category: ports >Synopsis: games/kdegames3 installs some files with invalid uid and gid >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun May 30 17:30:22 PDT 2004 >Closed-Date: >Last-Modified: >Originator: Taoka Fumiyoshi >Release: FreeBSD 5.2-CURRENT i386 >Organization: >Environment: >Description: games/kdegames3 installs some file with invalid uid and gid. They are untared directly into /usr/local/share/apps/kgoldrunner/system/levels. However they are immediately chowned to root.root, it fails. FreeBSD's chown currently uses not `.' but ':' as uid:gid separator and their group should be not `root' but `wheel'. The failure is hardly noticed during `make install' because its output goes to /dev/null and its return code is override by true in a makefile. >How-To-Repeat: # make install # ls -l /usr/local/share/apps/kgoldrunner/system/levels total 352 -rw-r--r-- 1 500 100 621 Dec 9 20:17 fred -rw-r--r-- 1 500 100 561 Jan 24 2002 level000.grl -rw-r--r-- 1 500 100 561 Jan 24 2002 level001.grl -rw-r--r-- 1 500 100 561 Jan 24 2002 level002.grl -rw-r--r-- 1 500 100 561 Jan 24 2002 level003.grl -rw-r--r-- 1 500 100 561 Jan 24 2002 level004.grl -rw-r--r-- 1 500 100 561 Jan 24 2002 level005.grl (snip) >Fix: diff -uN files.orig/patch-aa files/patch-aa --- files.orig/patch-aa Thu Jan 1 09:00:00 1970 +++ files/patch-aa Mon May 31 08:27:14 2004 @@ -0,0 +1,9 @@ +--- kgoldrunner/gamedata/Makefile.am Mon.orig May 31 07:55:56 2004 ++++ kgoldrunner/gamedata/Makefile.am Mon May 31 07:56:16 2004 +@@ -8,6 +8,6 @@ + $(mkinstalldirs) $(DESTDIR)$(gamedatadir) + pwd=`cd $(srcdir) && pwd` ;\ + cd $(DESTDIR)$(gamedatadir) && tar -xf $$pwd/levels.tar ;\ +- chown -R root.root levels 2> /dev/null || true ;\ ++ chown -R root:wheel levels 2> /dev/null || true ;\ + chmod 644 levels/* 2> /dev/null || true diff -uN files.orig/patch-ab files/patch-ab --- files.orig/patch-ab Thu Jan 1 09:00:00 1970 +++ files/patch-ab Mon May 31 08:27:25 2004 @@ -0,0 +1,11 @@ +--- kgoldrunner/gamedata/Makefile.in.orig Mon May 31 08:12:02 2004 ++++ kgoldrunner/gamedata/Makefile.in Mon May 31 08:13:28 2004 +@@ -561,7 +561,7 @@ + $(mkinstalldirs) $(DESTDIR)$(gamedatadir) + pwd=`cd $(srcdir) && pwd` ;\ + cd $(DESTDIR)$(gamedatadir) && tar -xf $$pwd/levels.tar ;\ +- chown -R root.root levels 2> /dev/null || true ;\ ++ chown -R root:wheel levels 2> /dev/null || true ;\ + chmod 644 levels/* 2> /dev/null || true + # Tell versions [3.59,3.63) of GNU make to not export all variables. + # Otherwise a system limit (for SysV at least) may be exceeded. >Release-Note: >Audit-Trail: >Unformatted: