Date: Sat, 08 Jul 2017 14:38:18 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Matthew Rezny <rezny@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r445076 - in head/x11-servers: xorg-nestserver/files xorg-server xorg-server/files xorg-vfbserver/files xwayland/files Message-ID: <o9sv-9k91-wny@FreeBSD.org> In-Reply-To: <1759815.Tk37oZ9O8z@workstation.reztek> (Matthew Rezny's message of "Sat, 08 Jul 2017 12:54:34 %2B0200") References: <201707051241.v65CfvFD096993@repo.freebsd.org> <1759815.Tk37oZ9O8z@workstation.reztek>
next in thread | previous in thread | raw e-mail | index | archive | help
Matthew Rezny <rezny@freebsd.org> writes: > Since fcntl is used to add FD_CLOEXEC after the unlink, there is zero > functional difference between using mkstemp and mkostemp with O_CLOEXEC. > Therefore, the the patch is entirely unnecessary cruft. Not zero, see existing HAVE_MKOSTEMP check in hw/xwayland/xwayland-shm.c. This change was about *atomic* close-on-exec. Anyway, I've sent a better version upstream.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?o9sv-9k91-wny>