From owner-freebsd-ports@FreeBSD.ORG Thu Dec 2 22:50:15 2010 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0E7E81065670 for ; Thu, 2 Dec 2010 22:50:15 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-iw0-f182.google.com (mail-iw0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id CB7EB8FC18 for ; Thu, 2 Dec 2010 22:50:14 +0000 (UTC) Received: by iwn39 with SMTP id 39so10361259iwn.13 for ; Thu, 02 Dec 2010 14:50:14 -0800 (PST) Received: by 10.231.14.74 with SMTP id f10mr845034iba.194.1291330214091; Thu, 02 Dec 2010 14:50:14 -0800 (PST) MIME-Version: 1.0 Received: by 10.231.79.82 with HTTP; Thu, 2 Dec 2010 14:49:53 -0800 (PST) From: Eitan Adler Date: Thu, 2 Dec 2010 17:49:53 -0500 Message-ID: To: freebsd ports Content-Type: text/plain; charset=UTF-8 Subject: A few questions about bsd.port.mk X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Dec 2010 22:50:15 -0000 I noticed a line in bsd.port.mk "Kludge for pre-3.0 systems" # Kludge for pre-3.0 ystems MACHINE_ARCH?= i386 According to cvs blame asami@ added both lines in revision 1.306 in 1999 Furthermore in bsd.port.mk it says ports should test against ARCH and not MACHINE_ARCH but bsd.port.subdir.mk uses MACHINE_ARCH on line 209. bsd.gnustep.mk has a similar test for MACHINE_ARCH instead of ARCH on line 136 (r1.1 by dinoex) 1) Should the initial line be removed 2) Should bsd.port.subdir.mk be changed to use ARCH instead? 3) Should bsd.gnustep.mk be changed to use ARCH instead? Overall I've been finding lots of inconsistent old hacks in bsd.*.mk and its difficult to tell which ones are still needed and which ones are not :-( -- Eitan Adler