From owner-freebsd-ports-bugs@FreeBSD.ORG Sat Feb 21 23:10:03 2009 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0536F1065674 for ; Sat, 21 Feb 2009 23:10:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D46EE8FC1C for ; Sat, 21 Feb 2009 23:10:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n1LNA2cY034357 for ; Sat, 21 Feb 2009 23:10:02 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n1LNA2cF034356; Sat, 21 Feb 2009 23:10:02 GMT (envelope-from gnats) Resent-Date: Sat, 21 Feb 2009 23:10:02 GMT Resent-Message-Id: <200902212310.n1LNA2cF034356@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jan Henrik Sylvester Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4E3C3106564A for ; Sat, 21 Feb 2009 23:09:15 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 222C38FC0C for ; Sat, 21 Feb 2009 23:09:15 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n1LN9E6h076655 for ; Sat, 21 Feb 2009 23:09:14 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n1LN9EvJ076648; Sat, 21 Feb 2009 23:09:14 GMT (envelope-from nobody) Message-Id: <200902212309.n1LN9EvJ076648@www.freebsd.org> Date: Sat, 21 Feb 2009 23:09:14 GMT From: Jan Henrik Sylvester To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/131955: multimedia/libxine links libfaad.so.2 if present X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Feb 2009 23:10:03 -0000 >Number: 131955 >Category: ports >Synopsis: multimedia/libxine links libfaad.so.2 if present >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sat Feb 21 23:10:02 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Jan Henrik Sylvester >Release: 7.1-RELEASE-p3 i386 >Organization: >Environment: >Description: If libfaad.so.2 from audio/faad is installed, multimedia/libxine uses it instead of building the internal one. The dependency is not recorded. There should be an OPTION, if the internal or external libfaad is to be used. It could default to off, since the dependency was not in the default package before. Or it could default to on, since configure states: --with-external-libfaad use external libfaad (recommended) >How-To-Repeat: - install audio/faad - install multimedia/libxine - readelf -d /usr/local/lib/xine/plugins/1.24/xineplug_decode_faad.so - observe that libfaad.so.2 is NEEDED >Fix: The patch attached adds an OPTION WITH_FAAD that will configure --with-external-libfaad=yes and record the dependency if on and configure --with-external-libfaad=no otherwise. (The default is off to be conservative, but that is against recommendation in configure.) Patch attached with submission follows: diff -u multimedia/libxine/Makefile.orig multimedia/libxine/Makefile --- multimedia/libxine/Makefile.orig 2009-02-10 20:50:54.000000000 +0100 +++ multimedia/libxine/Makefile 2009-02-21 23:20:56.000000000 +0100 @@ -63,7 +63,8 @@ AALIB "Enable aalib support" off \ IMAGEMAGICK "Enable ImageMagick support" off \ GTK2 "Enable gdkpixbuf support" off \ - WAVPACK "Enable WavPack support" on + WAVPACK "Enable WavPack support" on \ + FAAD "Enable external faad support" off MAN1= xine-config.1 xine-list-1.1.1 MAN5= xine.5 @@ -177,6 +178,13 @@ CONFIGURE_ARGS+= --without-wavpack .endif +.if defined(WITH_FAAD) +LIB_DEPENDS+= faad.2:${PORTSDIR}/audio/faad +CONFIGURE_ARGS+= --with-external-libfaad=yes +.else +CONFIGURE_ARGS+= --with-external-libfaad=no +.endif + .if ${CONFIGURE_ARGS:M*--without-imagemagick*} == "" || ${CONFIGURE_ARGS:M*-disable-gdkpixbuf*} == "" PLIST_SUB+= WITH_DMX_IMAGE="" .else >Release-Note: >Audit-Trail: >Unformatted: