From owner-svn-src-head@freebsd.org Mon Aug 3 10:37:28 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9B9039B184A for ; Mon, 3 Aug 2015 10:37:28 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 3ABE41EB7 for ; Mon, 3 Aug 2015 10:37:27 +0000 (UTC) (envelope-from steven@multiplay.co.uk) Received: by wibud3 with SMTP id ud3so130131654wib.1 for ; Mon, 03 Aug 2015 03:37:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:subject:to:references:cc:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=FLGnY8o7utKEFJqjWoqlKZfcM5ShQsWRMGshtaWoeXU=; b=QiAQf3rfo3iUVXGQ0HiZZI5fOiiY4ByThpu6R8KE2FxbsGRHGPvG9X/z+9wZIvDeP9 foyA+ieNy57s9hohO6IcIOpkWN2Lb3dEV/jnXLdR1SvJYTraarwgw3wZ9E4N36T+jEFO UJhbNkhab+dxvU9fhYfyXWcqI7FxizsXV2IJofrd1JM+unEvnbvWLmMX2EpPJhBunJKG o6VgOSjyhH/wVfhi4+u8NbN9a7rfTZSPIg6ragcDLiU8owhpINh0zhYnqjd6585juv1j 6zwkQ+5+sTOjqlbIsYsPisdmYLITwnh9IhtqmnCDIIJXwj+ITD65vmeuC0ENvN8K+KOL EqdA== X-Gm-Message-State: ALoCoQkj4I3ABr4xqZpZpcCuFKMAA9lT3gAaQBgmkZKdFLzLxgp3fONM6WjDrROIvgRGFutq22Yg X-Received: by 10.180.198.178 with SMTP id jd18mr32689901wic.14.1438597912194; Mon, 03 Aug 2015 03:31:52 -0700 (PDT) Received: from [10.10.1.68] (82-69-141-170.dsl.in-addr.zen.co.uk. [82.69.141.170]) by smtp.gmail.com with ESMTPSA id pn6sm22161131wjb.36.2015.08.03.03.31.51 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2015 03:31:51 -0700 (PDT) From: Steven Hartland X-Google-Original-From: Steven Hartland Subject: Re: svn commit: r286223 - head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs To: Slawa Olhovchenkov References: <201508030934.t739YAkT026668@repo.freebsd.org> <20150803094730.GA24698@zxy.spb.ru> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <55BF431E.3020601@freebsd.org> Date: Mon, 3 Aug 2015 11:31:58 +0100 User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20150803094730.GA24698@zxy.spb.ru> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Aug 2015 10:37:28 -0000 On 03/08/2015 10:47, Slawa Olhovchenkov wrote: > On Mon, Aug 03, 2015 at 09:34:10AM +0000, Steven Hartland wrote: > >> Author: smh >> Date: Mon Aug 3 09:34:09 2015 >> New Revision: 286223 >> URL: https://svnweb.freebsd.org/changeset/base/286223 >> >> Log: >> Fix KSTACK_PAGES check in ZFS module >> >> The check introduced by r285946 failed to add the dependency on >> opt_kstack_pages.h which meant the default value for the platform instead >> of the customised options KSTACK_PAGES=X was being tested. >> >> Also wrap in #ifdef __FreeBSD__ for portability. > /usr/src/sys/kern/kern_proc.c:int kstack_pages = KSTACK_PAGES; > > May be check variable kstack_pages is best way? > Eliminate dependency on foreign opt_XXXX. > I did think of that but as other modules such as dtrace, which is also cddl code, already have this dependency I went with this. I'm easy though, if there's a concusses that kstack_pages or possibly curthread->td_kstack_pages, which would take into account the possibility of varied thread stack sizes, then I can make that change. What do others think? Regards Steve