From owner-freebsd-net@FreeBSD.ORG Sun Mar 1 12:50:17 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 20AA2D8B for ; Sun, 1 Mar 2015 12:50:17 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 007E5AD9 for ; Sun, 1 Mar 2015 12:50:16 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t21CoG4H033480 for ; Sun, 1 Mar 2015 12:50:16 GMT (envelope-from root@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t21CoGHX033479; Sun, 1 Mar 2015 12:50:16 GMT (envelope-from root) Date: Sun, 1 Mar 2015 12:50:16 +0000 To: freebsd-net@freebsd.org From: "ae (Andrey V. Elsukov)" Subject: [Differential] [Changed Subscribers] D1986: Teach lagg(4) to change MTU Message-ID: <255974716a5da874d653152fa3c43a7e@localhost.localdomain> X-Priority: 3 Thread-Topic: D1986: Teach lagg(4) to change MTU X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: ODZhMzNlYThiYzMxOTgzYmRhMDE5M2Q2Yzk4IFTzCwg= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 01 Mar 2015 12:50:17 -0000 ae added a subscriber: ae. ae added a comment. Just a thought. Imagine two interfaces, one has maximum MTU 2200, another 1500. lagg0 has MTU 1400. Two threads invokes changing MTU in the same time. One wants to change it to 2000, another - to 1500. It is possible, that when both threads will finish its job, one interface will have MTU 1400, but another - 1500. I mean, that such changes should be done exclusively without possibility of races in the ioctl code. REVISION DETAIL https://reviews.freebsd.org/D1986 To: rpokala-panasas.com, rstone Cc: ae, freebsd-net