From nobody Sat Oct 11 12:03:56 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ckMhr46cqz6BlF4; Sat, 11 Oct 2025 12:03:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ckMhr2WySz3rSm; Sat, 11 Oct 2025 12:03:56 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760184236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FUkEr/Aa/R913myHoY7Rn67OivHjYrCAgoBGwC8i1gE=; b=CocPe5Y+RUFMxPqbPuNZzZHzMnoEZxl1DDkwf8hfCqY/YrN5rqGh/s1Z/7hN40iuhCRIg2 SGbzBpKN6w/rfMd3qNfP4GPQck+7e592nAFhy4jBG/12seCwH4bYFV0T6b9ki/qvyVyNNJ hknCRvLIMClOm9Ua4KchAYvNA9srmUS1SFxsWaIXLerliahB+ZVu1EVysWV8fQe1H/yu5m iCpxqo7DhF5RByecdZdGv6lh/s89icX0i8BMwSC7iL6t+7Xb9vZP4DtDnx67fA3MzzLyqc qggqLa5d+Pt0HwEGpU3TUQAWWOBPlz6nx/5iVVNEKexLyISpcpbE+/bebEfWOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760184236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=FUkEr/Aa/R913myHoY7Rn67OivHjYrCAgoBGwC8i1gE=; b=I6BniHoGGb3ywF382FkRD6hkPX6iTyOvVha1Yin1zh+VRK7DgQz6JL/4Ie9tlDZQaDqQ6n D2NH75OefMmnUhbdtHBx/Wz6mqrhBvKxMu4MrToJLrfZMRRyR04KDsePIjPG7vFKneVE5Q njKR7+J8aclFZeDqbWDsb+nQBFXKDnhPZ70QlMzXYmTFApzpgU8R83hjfGzPTSZvFcbSyR z/K3plMuQ1N2vvDhjW+0jEg9kIUyux77lVE9i/vXIjBLJQwvkgSluRrlo41XwzrLY8oq4H 8hlmzGy/9b4bt0NPvlFCAQ5FPRngJ4CjlVUmIFPfSuyjxC0cEiVoAegspEo5zA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1760184236; a=rsa-sha256; cv=none; b=Cv6a6SjMFKZQ5pe5+UZ9PdcavlEllALuyVxC8DmQofEgiy/u8Z+Tw3Q3I93FpcZBB2gFhC Nvp0MNl6Fsj0DYe0/FrKyeK0C3GsmMOj8Z8HNAPXpJibAT7yv+NfNQ8NPEEz1o8LQR4zgH rxcMxnEjJMY7kCzB4Aebggx6wp2uP0WXH8++NoCj2pbKLTQApUylJI/Ri94WaweXpH+lFm gtqWOo5Xjj38gHbmfeEAWWSi/cdnM/nhFaoY2Xr5dK5AWYPWr6SzaF2bMbaySGGfIY8GZ7 +igYHsg3RBzUWatCFhOj5RmSLbUPa64YY+HtH3B2RVLa5pW+hsPuWhmMIHBD/A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ckMhr1qjPzZdb; Sat, 11 Oct 2025 12:03:56 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59BC3ul2040049; Sat, 11 Oct 2025 12:03:56 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59BC3uKR040046; Sat, 11 Oct 2025 12:03:56 GMT (envelope-from git) Date: Sat, 11 Oct 2025 12:03:56 GMT Message-Id: <202510111203.59BC3uKR040046@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 02923dd9b0de - main - dummynet: SDT probe dropped packets List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 02923dd9b0de050b989b5a4103e402055cb7f61a Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=02923dd9b0de050b989b5a4103e402055cb7f61a commit 02923dd9b0de050b989b5a4103e402055cb7f61a Author: Kristof Provost AuthorDate: 2025-10-10 10:06:21 +0000 Commit: Kristof Provost CommitDate: 2025-10-11 11:24:25 +0000 dummynet: SDT probe dropped packets Add static probe points to track where we increment io_pkt_drop. This is intended to assist in debugging dummynet, allowing us to work out when and hopefully why packets get dropped. Sponsored by: Rubicon Communications, LLC ("Netgate") --- sys/netpfil/ipfw/ip_dn_io.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sys/netpfil/ipfw/ip_dn_io.c b/sys/netpfil/ipfw/ip_dn_io.c index 03116cb0641c..3a8de2b2bfee 100644 --- a/sys/netpfil/ipfw/ip_dn_io.c +++ b/sys/netpfil/ipfw/ip_dn_io.c @@ -43,6 +43,7 @@ #include #include #include +#include #include #include #include @@ -70,6 +71,9 @@ #endif #include +SDT_PROVIDER_DEFINE(dummynet); +SDT_PROBE_DEFINE2(dummynet, , , drop, "struct mbuf *", "struct dn_queue *"); + /* * We keep a private variable for the simulation time, but we could * probably use an existing one ("softticks" in sys/kern/kern_timeout.c) @@ -545,6 +549,7 @@ dn_enqueue(struct dn_queue *q, struct mbuf* m, int drop) drop: V_dn_cfg.io_pkt_drop++; + SDT_PROBE2(dummynet, , , drop, m, q); q->ni.drops++; ni->drops++; FREE_PKT(m); @@ -1001,6 +1006,7 @@ done: dropit: V_dn_cfg.io_pkt_drop++; + SDT_PROBE2(dummynet, , , drop, m, q); DN_BH_WUNLOCK(); if (m) FREE_PKT(m);