Date: Sat, 08 Jul 2017 14:48:44 +0200 From: Jan Beich <jbeich@FreeBSD.org> To: Matthew Rezny <rezny@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r445016 - in head/x11/libxshmfence: . files Message-ID: <inj3-8577-wny@FreeBSD.org> In-Reply-To: <2370475.W49dQvnFxO@workstation.reztek> (Matthew Rezny's message of "Sat, 08 Jul 2017 12:45:57 %2B0200") References: <201707041347.v64Dlkx7028953@repo.freebsd.org> <2370475.W49dQvnFxO@workstation.reztek>
next in thread | previous in thread | raw e-mail | index | archive | help
Matthew Rezny <rezny@freebsd.org> writes: >> ++#ifdef HAVE_MKOSTEMP >> ++ fd = mkostemp(template, O_CLOEXEC); >> ++#else >> + fd = mkstemp(template); >> ++#endif >> + if (fd < 0) >> + return fd; >> + unlink(template); > > Please explain this unauthorized non-maintainer commit that lacks any PR or > review. In PR 217676 the maintainer explicitly stated they didn't test DRI3 and disregarded the issue. Maintainers are supposed to upstream changes to prevent downstream-only bugs like we've seen here. > Mentioning a closed PR does notyt count. This sort of change really > needs to be reviewed by the maintainer(s) before it is committed. Understood. I'd ask you to not *modify* my patches without approval as well. Let's not repeat beignet mistakes where upstream understood me better. > Againb, I must assume this is wholly untested because there has been > no mention of QA. QA is mandatory for committers. I did check DRI2 and DRI3 don't work and don't orphan files.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?inj3-8577-wny>