Date: Fri, 6 Dec 2013 19:57:34 +0400 From: Eygene Ryabinkin <rea@freebsd.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, "Sergey A. Osokin" <osa@FreeBSD.org>, ports-committers@freebsd.org Subject: Re: svn commit: r335584 - head/www/nginx/files Message-ID: <776%2BHef2F6wPoijMZp0QCw7dq7s@oWPesh4l9zh3TEEafuAJpu%2BpO6A> In-Reply-To: <6C5CAF4A651E78FA0271987C@ogg.in.absolight.net> References: <201312031808.rB3I8LX3026752@svn.freebsd.org> <2810458563ECCE4995A6F346@ogg.in.absolight.net> <vC8bOu99RjKuU8c6B28CX9Bf9W8@hAm863D/O7ToqOy9f4TrItu8xPI> <6C5CAF4A651E78FA0271987C@ogg.in.absolight.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--vhOf6eAHdfH9MSjZ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Fri, Dec 06, 2013 at 04:27:22PM +0100, Mathieu Arnold wrote: > +--On 6 d=C3=A9cembre 2013 18:56:13 +0400 Eygene Ryabinkin <rea@freebsd.o= rg> > wrote: > | Nginx without syslog support will reject all configuration directives > | like 'syslog daemon', so people were either not using syslog at all > | or were patching the patch to properly embed syslog support into nginx. > |=20 > | Supposedly, the second category of people will get nginx with > | enable-able syslog support from vanilla port at the next update > | of their tree. SYSLOG_SUPPORT is off by-default, so packages won't > | be affected too. >=20 > Packages built with the default options won't be affected, yes. > But for people not using packages, or building packages with non default > options won't know there is a new version of the port. Well, there are three kinds of users who aren't using packages or are customizing them: - running with modified patch that will properly enable syslog support; they won't get anything new from this commit; - those who don't need syslog support; no news for them too; - those who wanted syslog support, built the port with it enabled, but got Nginx without syslog support and are looking for the port to be fixed. Only third category of people can really require PORTREVISION bump. I wasn't much convinced that they will get anything sensible from it, because it won't magically "just work" for them, they will need to upgrade their configs too. Those who use custom packages will really be in trouble: they won't get syslog support until PORTREVISION bump (unless they will replace current package with the new one by hand). Users who install directly from ports will, probably, fine, because the only way to discover that syslog is now unbroken is to read commit logs (or UPDATING); after this it is easy to do 'make all deinstall install clean'. > You have to bump PORTREVISION when what you change can change the > package. That's a rule of the thumb, but not a strict requirement at all times, as I understand it. So in this situation I am not very much sure that happiness from PORTVERSION bump will outweight the need for upgrade by everyone who uses Nginx. Though I may be wrong. --=20 Eygene Ryabinkin ,,,^..^,,, [ Life's unfair - but root password helps! | codelabs.ru ] [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] --vhOf6eAHdfH9MSjZ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iL4EABEKAGYFAlKh8+5fFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl bnBncC5maWZ0aGhvcnNlbWFuLm5ldDgyRkUwNkJDRDQ5N0MwREU0OUVDNEZGMDE2 QUY5RUFFODE1MkVDRkIACgkQFq+eroFS7PuHWAD9HX+yJ2XtsTMu9Zp+mXkWH8cd qslt318BaajeRnk9IxAA/2HBXf3eJVlQLm6pqxGNi2YdZYdRnnxzBn+UdgKYg+cA =HYti -----END PGP SIGNATURE----- --vhOf6eAHdfH9MSjZ--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?776%2BHef2F6wPoijMZp0QCw7dq7s>