From owner-freebsd-current@FreeBSD.ORG Wed May 5 10:25:48 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AABDA106566C for ; Wed, 5 May 2010 10:25:48 +0000 (UTC) (envelope-from rfarmer@predatorlabs.net) Received: from mail-yx0-f175.google.com (mail-yx0-f175.google.com [209.85.210.175]) by mx1.freebsd.org (Postfix) with ESMTP id 715DD8FC23 for ; Wed, 5 May 2010 10:25:48 +0000 (UTC) Received: by yxe5 with SMTP id 5so1628215yxe.3 for ; Wed, 05 May 2010 03:25:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.150.31.18 with SMTP id e18mr7450009ybe.218.1273055139964; Wed, 05 May 2010 03:25:39 -0700 (PDT) Received: by 10.151.107.7 with HTTP; Wed, 5 May 2010 03:25:39 -0700 (PDT) X-Originating-IP: [128.95.133.196] In-Reply-To: References: Date: Wed, 5 May 2010 03:25:39 -0700 Message-ID: From: Rob Farmer To: David DEMELIER Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-current@freebsd.org Subject: Re: unzip in basesystem. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 May 2010 10:25:48 -0000 On Wed, May 5, 2010 at 2:30 AM, David DEMELIER w= rote: > 2010/5/5 David DEMELIER : >> Hi, >> >> I noticed that unzip came into basesystem in src/usr.bin/unzip/. To >> prevent port installing the ports/archivers/unzip one, I propose to >> add this in bsd.port.mk Unfortunately there are some problems with the base system unzip that make it preferable to use the port. From the commit log for bsd.port.mk: 9-CURRENT introduced unzip command to the base system. Unfortunately it = is not fully compatible with the archivers/unzip implementation and non-triv= ial amount of ports fail to build when using it. Thus we will keep using archivers/unzip for unzipping source in Ports Collection until someone volunteer to fix all individual ports. Two most common problems with bas= e unzip are: * extracting files without +x flag (some ports rely to execute unzipped configure scripts, for example) * different semantics of CR/LF conversion Error logs of failed port builds with in-base unzip can be made available= on request to portmgr@. With hat: portmgr --=20 Rob Farmer >> >> .if defined(USE_ZIP) && !exists(/usr/bin/unzip) >> EXTRACT_DEPENDS+=3D =A0 =A0 =A0 ${LOCALBASE}/bin/unzip:${PORTSDIR}/archi= vers/unzip >> .endif >> >> Is that right ? >> > > Sorry I gone too fast, I would add this in bsd.commands.mk too : > > .if exists(/usr/bin/unzip) > UNZIP_CMD=3D/usr/bin/unzip > .else > UNZIP_CMD?=3D =A0 =A0 ${LOCALBASE}/bin/unzip > .endif > > -- > Demelier David > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org= " >