From owner-svn-src-head@FreeBSD.ORG  Tue Oct  2 20:50:03 2012
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 3BFBC106564A;
	Tue,  2 Oct 2012 20:50:03 +0000 (UTC)
	(envelope-from yanegomi@gmail.com)
Received: from mail-ie0-f182.google.com (mail-ie0-f182.google.com
	[209.85.223.182])
	by mx1.freebsd.org (Postfix) with ESMTP id BE31B8FC0A;
	Tue,  2 Oct 2012 20:50:02 +0000 (UTC)
Received: by ieak10 with SMTP id k10so14636518iea.13
	for <multiple recipients>; Tue, 02 Oct 2012 13:50:02 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:in-reply-to:references:date:message-id:subject:from:to
	:cc:content-type;
	bh=avfHUzGBqaRGl64d/c2cscE44H74ZoA3zoa9Tat3+wE=;
	b=SbZleYT5VoamMNgtOhf4Owqu8suYkQ5SS0Q/PQQTr019nURGx+Qbv4IHU4EpGFr0Du
	+OLp8wDk43HSEijoFzli1S4NtTlTUvRE4tGotQX+IKzvnBN81BxYbyDKO6RrRb4Bd2Ka
	YcKSZe7ELvOwV6k8uZR7RgycO7qFEIpdlxEUbeJjV5++jLVux1yBY2q1Ccjtozv4HG3c
	CiGBrB1GBnVmgTefJZj6nZ641ME4IxCe+5jJQAv9nu7oDq1krB+i+B+4jK9cceX/dKVR
	v8AUeqBETYCZ7a9LZdj0c+PDaFsaSHMmDMPRVqSuuEmKKwThbt9LmdWRZ7HSoJ/ev78C
	r5Dw==
MIME-Version: 1.0
Received: by 10.50.184.129 with SMTP id eu1mr13743igc.0.1349211001880; Tue, 02
	Oct 2012 13:50:01 -0700 (PDT)
Received: by 10.64.51.39 with HTTP; Tue, 2 Oct 2012 13:50:01 -0700 (PDT)
In-Reply-To: <20121002193846.GX50433@FreeBSD.org>
References: <201210021838.q92Ic55R085388@svn.freebsd.org>
	<20121002193846.GX50433@FreeBSD.org>
Date: Tue, 2 Oct 2012 13:50:01 -0700
Message-ID: <CAGH67wSjSukE=U6+rJrqn+H2LiCjqVUXaU5mB-dXR2sf6=XFVQ@mail.gmail.com>
From: Garrett Cooper <yanegomi@gmail.com>
To: Gleb Smirnoff <glebius@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Garrett Wollman <wollman@freebsd.org>
Subject: Re: svn commit: r241140 - head/sys/kern
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 02 Oct 2012 20:50:03 -0000

On Tue, Oct 2, 2012 at 12:38 PM, Gleb Smirnoff <glebius@freebsd.org> wrote:
> On Tue, Oct 02, 2012 at 06:38:05PM +0000, Garrett Wollman wrote:
> G> Author: wollman
> G> Date: Tue Oct  2 18:38:05 2012
> G> New Revision: 241140
> G> URL: http://svn.freebsd.org/changeset/base/241140
> G>
> G> Log:
> G>   Fix spelling of the function name in two assertion messages.
> G>
> G> Modified:
> G>   head/sys/kern/uipc_socket.c
> G>
> G> Modified: head/sys/kern/uipc_socket.c
> G> ==============================================================================
> G> --- head/sys/kern/uipc_socket.c      Tue Oct  2 17:46:32 2012        (r241139)
> G> +++ head/sys/kern/uipc_socket.c      Tue Oct  2 18:38:05 2012        (r241140)
> G> @@ -995,9 +995,9 @@ sosend_dgram(struct socket *so, struct s
> G>      int atomic = sosendallatonce(so) || top;
> G>  #endif
> G>
> G> -    KASSERT(so->so_type == SOCK_DGRAM, ("sodgram_send: !SOCK_DGRAM"));
> G> +    KASSERT(so->so_type == SOCK_DGRAM, ("sosend_dgram: !SOCK_DGRAM"));
> G>      KASSERT(so->so_proto->pr_flags & PR_ATOMIC,
> G> -        ("sodgram_send: !PR_ATOMIC"));
> G> +        ("sosend_dgram: !PR_ATOMIC"));
> G>
> G>      if (uio != NULL)
> G>              resid = uio->uio_resid;
>
> Why not to use just __func__ here?

    Just reiterating the argument that was posed before: it's harder
to grep that way (even though, technically one could do better with
__func__ and __LINE__, etc if they were truly looking for
readability).
Thanks,
-Garrett