From owner-freebsd-security Thu Apr 5 17:49:37 2001 Delivered-To: freebsd-security@freebsd.org Received: from Awfulhak.org (awfulhak.demon.co.uk [194.222.196.252]) by hub.freebsd.org (Postfix) with ESMTP id 7685237B424 for ; Thu, 5 Apr 2001 17:49:29 -0700 (PDT) (envelope-from brian@Awfulhak.org) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [172.16.0.12]) by Awfulhak.org (8.11.3/8.11.3) with ESMTP id f360nZU13246; Fri, 6 Apr 2001 01:49:35 +0100 (BST) (envelope-from brian@lan.Awfulhak.org) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.3/8.11.3) with ESMTP id f360nVP03735; Fri, 6 Apr 2001 01:49:31 +0100 (BST) (envelope-from brian@hak.lan.Awfulhak.org) Message-Id: <200104060049.f360nVP03735@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.3.1 01/18/2001 with nmh-1.0.4 To: Garrett Wollman Cc: Brian Somers , security@FreeBSD.ORG, brian@Awfulhak.org Subject: Re: ntpd patch In-Reply-To: Message from Garrett Wollman of "Thu, 05 Apr 2001 20:38:02 EDT." <200104060038.UAA73318@khavrinen.lcs.mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 06 Apr 2001 01:49:31 +0100 From: Brian Somers Sender: owner-freebsd-security@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org > < said: > > > I believe the int is correct. > > You are mistaken. The purpose of the cast is to defeat the automatic > promotion from `char' to `int', which causes sign-extension if `char' > is signed. Casting to `unsigned char' prevents this from happening. Oops, yes... I guess I'll go to bed now then :*I > -GAWollman -- Brian Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-security" in the body of the message