From owner-svn-src-all@freebsd.org Sat Oct 27 21:31:06 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C6EFF10D4ADA; Sat, 27 Oct 2018 21:31:06 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from mail.daemonic.se (mail.daemonic.se [176.58.89.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 6776A7C71C; Sat, 27 Oct 2018 21:31:06 +0000 (UTC) (envelope-from zeising@freebsd.org) Received: from cid.daemonic.se (localhost [IPv6:::1]) by mail.daemonic.se (Postfix) with ESMTP id 42jDZ10JCTzDhxn; Sat, 27 Oct 2018 21:31:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at daemonic.se Received: from mail.daemonic.se ([IPv6:::1]) (using TLS with cipher ECDHE-RSA-AES128-GCM-SHA256) by cid.daemonic.se (mailscanner.daemonic.se [IPv6:::1]) (amavisd-new, port 10587) with ESMTPS id HV3EgYaJugqE; Sat, 27 Oct 2018 21:31:04 +0000 (UTC) Received: from garnet.daemonic.se (unknown [IPv6:2001:470:dca9:201:9eda:3eff:fe70:24c0]) by mail.daemonic.se (Postfix) with ESMTPSA id 42jDZ030pXzDhFd; Sat, 27 Oct 2018 21:31:04 +0000 (UTC) Subject: Re: svn commit: r339823 - in head/sys/dev: atkbdc evdev kbdmux usb/input To: Vladimir Kondratyev , Vladimir Kondratyev , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201810272022.w9RKMgOZ023575@repo.freebsd.org> <3d441b5d-e225-1226-e229-73c93f85c8a9@freebsd.org> <82231f6b-41c4-8beb-771d-3b6ada56091c@kondratyev.su> From: Niclas Zeising Message-ID: <22411251-9d2b-8799-3914-28974a9710f2@freebsd.org> Date: Sat, 27 Oct 2018 23:31:04 +0200 User-Agent: Mutt/1.5.21 MIME-Version: 1.0 In-Reply-To: <82231f6b-41c4-8beb-771d-3b6ada56091c@kondratyev.su> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Oct 2018 21:31:06 -0000 On 10/27/18 11:26 PM, Vladimir Kondratyev wrote: > On 27.10.2018 23:32, Niclas Zeising wrote: >> On 10/27/18 10:22 PM, Vladimir Kondratyev wrote: >>> Author: wulf >>> Date: Sat Oct 27 20:22:41 2018 >>> New Revision: 339823 >>> URL: https://svnweb.freebsd.org/changeset/base/339823 >>> >>> Log: >>> =C2=A0=C2=A0 evdev: Use console lock as evdev lock for all supported= keyboard >>> drivers. >>> =C2=A0=C2=A0 =C2=A0=C2=A0 Now evdev part of keyboard drivers does no= t take any locks if >>> corresponding >>> =C2=A0=C2=A0 input/eventN device node is not opened by userland cons= umers. >>> =C2=A0=C2=A0 =C2=A0=C2=A0 Do not assert console lock inside evdev to= handle the cases >>> when keyboard >>> =C2=A0=C2=A0 driver is called from some special single-threaded cont= ext like >>> shutdown >>> =C2=A0=C2=A0 thread. >>> >> Related to https://reviews.freebsd.org/D15070 ? >> > Yes it is a part of D15070. >=20 > Along with r339824 it closes all issues known to me that preventing > evdev to be enabled by default. >=20 Thank you! Any chance you can add a note in phabricator and close/abandon the review= ? Once again thank you! Regards --=20 Niclas Zeising