From owner-cvs-src@FreeBSD.ORG Tue Apr 4 17:34:11 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 0B03516A41F; Tue, 4 Apr 2006 17:34:11 +0000 (UTC) (envelope-from ariff@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 914B843D49; Tue, 4 Apr 2006 17:34:10 +0000 (GMT) (envelope-from ariff@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id k34HYAVI078932; Tue, 4 Apr 2006 17:34:10 GMT (envelope-from ariff@repoman.freebsd.org) Received: (from ariff@localhost) by repoman.freebsd.org (8.13.1/8.13.1/Submit) id k34HYADa078931; Tue, 4 Apr 2006 17:34:10 GMT (envelope-from ariff) Message-Id: <200604041734.k34HYADa078931@repoman.freebsd.org> From: Ariff Abdullah Date: Tue, 4 Apr 2006 17:34:10 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: RELENG_6 Cc: Subject: cvs commit: src/sys/dev/sound/usb uaudio.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2006 17:34:11 -0000 ariff 2006-04-04 17:34:10 UTC FreeBSD src repository Modified files: (Branch: RELENG_6) sys/dev/sound/usb uaudio.c Log: MFC (revision 1.20) Convert NULL checks into KASSERT (and move them before the first dereferencing) since a NULL value would be a bug here. Note: Both affected functions look very similar. A refactoring may be beneficial. CID: 483, 485 Found with: Coverity Prevent(tm) Approved by: re (scottl) Revision Changes Path 1.14.2.2 +11 -10 src/sys/dev/sound/usb/uaudio.c