Date: Sat, 19 Mar 2016 14:18:40 +0000 (UTC) From: Raphael Kubo da Costa <rakuco@FreeBSD.org> To: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: svn commit: r411399 - head/audio/fplib/files Message-ID: <201603191418.u2JEIeNj000224@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: rakuco Date: Sat Mar 19 14:18:40 2016 New Revision: 411399 URL: https://svnweb.freebsd.org/changeset/ports/411399 Log: Add a patch to explicitly link against libfplib.so. What the port was doing was never right, but the upcoming CMake 3.5.0 makes the build failures happen more often. Using target_link_libraries() with a name like fplib will just pass -lfplib to the linker instead of declaring a dependency between the lastfm-fpclient and fplib_shared targets and parallel builds may break. PR: 208033 Added: head/audio/fplib/files/ head/audio/fplib/files/patch-CMakeLists.txt (contents, props changed) Added: head/audio/fplib/files/patch-CMakeLists.txt ============================================================================== --- /dev/null 00:00:00 1970 (empty, because file is newly added) +++ head/audio/fplib/files/patch-CMakeLists.txt Sat Mar 19 14:18:40 2016 (r411399) @@ -0,0 +1,15 @@ +Link against an actual target name, not the generated library name. + +If we link against the latter, there is no dependency between lastfm-fpclient +and fplib, which can break parallel builds starting with CMake 3.5.0. +--- CMakeLists.txt.orig 2016-03-16 09:53:03 UTC ++++ CMakeLists.txt +@@ -139,7 +139,7 @@ ADD_EXECUTABLE(lastfm-fpclient + + # Link the executable + TARGET_LINK_LIBRARIES(lastfm-fpclient +- fplib ++ fplib_shared + fftw3f + mad + tag
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201603191418.u2JEIeNj000224>