From owner-freebsd-geom@FreeBSD.ORG Fri Apr 9 11:10:40 2010 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2BAF7106564A; Fri, 9 Apr 2010 11:10:40 +0000 (UTC) (envelope-from paul@fletchermoorland.co.uk) Received: from hydra.fletchermoorland.co.uk (hydra.fletchermoorland.co.uk [78.33.209.59]) by mx1.freebsd.org (Postfix) with ESMTP id 9D4378FC14; Fri, 9 Apr 2010 11:10:39 +0000 (UTC) Received: from demophon.fletchermoorland.co.uk (demophon.fletchermoorland.co.uk [192.168.0.154]) by hydra.fletchermoorland.co.uk (8.14.3/8.14.3) with ESMTP id o39AgIBH013568; Fri, 9 Apr 2010 11:42:19 +0100 (BST) (envelope-from paul@fletchermoorland.co.uk) Message-ID: <4BBF048A.407@fletchermoorland.co.uk> Date: Fri, 09 Apr 2010 10:42:18 +0000 From: Paul Wootton User-Agent: Thunderbird 2.0.0.23 (X11/20091217) MIME-Version: 1.0 To: =?UTF-8?B?RGFnLUVybGluZyBTbcO4cmdyYXY=?= References: <55861270658151@web135.yandex.ru> <20100408103809.13496s9i6ny03ocg@webmail.leidinger.net> <867hoi8gbl.fsf@ds4.des.no> <201004080849.12151.jhb@freebsd.org> <86r5mqt4aj.fsf@ds4.des.no> <86sk75ol54.fsf@ds4.des.no> <86fx356ku1.fsf@ds4.des.no> In-Reply-To: <86fx356ku1.fsf@ds4.des.no> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=2.5 required=10.0 tests=ALL_TRUSTED,BAYES_50, DNS_FROM_OPENWHOIS,FH_DATE_PAST_20XX autolearn=no version=3.2.5 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on hydra.fletchermoorland.co.uk Cc: Bruce Cran , freebsd-geom@freebsd.org, Alexander Leidinger , Teske , Randi Harper , freebsd-current@freebsd.org, "Andrey V. Elsukov" , Garrett Cooper Subject: Re: [RFC] Rewriting sade(8) X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 09 Apr 2010 11:10:40 -0000 Dag-Erling Smørgrav wrote: > Garrett Cooper writes: > >> Dag-Erling Smørgrav writes: >> >>> Garrett Cooper writes: >>> >>>> Dag-Erling Smørgrav writes: >>>> >>>>> [restored relevant context which was removed earlier in the thread] >>>>> ...which is exactly what I said - but in the sysinstall case, you may >>>>> want to ask some additional questions ("are you sure you want to proceed >>>>> without a swap partition?") or place some additional constraints (such >>>>> as "don't allow the user to mount something on top of /mnt or /rescue"), >>>>> and sysinstall needs to know the outcome. >>>>> >>>> If the user shoots him or herself in the foot, that's their own >>>> problem. >>>> >>> That kind of attitude is why people choose Linux over FreeBSD... >>> >> Where do you draw the line though? /media, /libexec, /proc, /sys, etc? >> I think it's better to educate users than build in more complexity to >> the install application. >> > > I draw the line at mounting something - anything - on top of directories > that contain files that are critical to sysinstall's operation. IIRC, > /mnt is where the installation CD is mounted. > > In sysinstall mode, sade's role is to 1) make sure that something > sensible is mounted in the location where sysinstall is going to install > the OS, 2) assist the user in making the correct disk, slice, partition > or what-have-you bootable, 3) within reasonable limits, prevent the user > from doing something that will break sysinstall, and 4) optionally allow > the user to prepare additional filesystems that sysinstall doesn't care > about (e.g. /usr/obj), as long as this does not conflict with 3). > > I think the easiest way to achieve this is for sysinstall to provide an > empty directory (e.g. /inst) and have sade operate with that directory > as root, so what the user sees is how things will look when the system > reboots after installation; when the user asks sade to create /usr/obj, > sade actually creates /inst/usr/obj. > > Last but not least, sade should report what it did to sysinstall - > perhaps in fstab format, since sysinstall needs to populate > (/inst)/etc/fstab anyway. > > DES > But... If this is a fresh install, then you really have not lost anything if you making a mistake. If sysinstall / sade is run from a running system and a mistake is made then you could loose your data, but as you will need to have su-ed up, how does this differ from typing a wrong command in? Just my 2 cents Paul