From owner-freebsd-cvsweb@FreeBSD.ORG Tue Jun 24 02:12:05 2003 Return-Path: Delivered-To: freebsd-cvsweb@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CC45837B401 for ; Tue, 24 Jun 2003 02:12:05 -0700 (PDT) Received: from smtp1.pp.htv.fi (smtp1.pp.htv.fi [212.90.64.111]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2DDEE43F3F for ; Tue, 24 Jun 2003 02:12:05 -0700 (PDT) (envelope-from scop@FreeBSD.org) Received: from posti.pp.htv.fi (posti.pp.htv.fi [212.90.64.50]) by smtp1.pp.htv.fi (Postfix) with ESMTP id 56E9280376 for ; Tue, 24 Jun 2003 12:12:04 +0300 (EEST) Received: from cs78130147.pp.htv.fi (cs78130147.pp.htv.fi [62.78.130.147]) by posti.pp.htv.fi (8.11.1/8.11.1) with ESMTP id h5O9EC901710 for ; Tue, 24 Jun 2003 12:14:12 +0300 (EETDST) From: Ville =?ISO-8859-1?Q?Skytt=E4?= To: freebsd-cvsweb@FreeBSD.org In-Reply-To: <001001c338f4$2f831000$0b00000a@a2000.nl> References: <001001c338f4$2f831000$0b00000a@a2000.nl> Content-Type: text/plain; charset=ISO-8859-1 Organization: FreeBSD Message-Id: <1056445923.23164.267.camel@bobcat.ods.org> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.2 (1.2.2-5) Date: 24 Jun 2003 12:12:03 +0300 Content-Transfer-Encoding: 8bit Subject: Re: Contribution: show different icon for icon for binary (-kb) files and show keyword expansion mode on the log page X-BeenThere: freebsd-cvsweb@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS Web maintenance mailing list [restricted posting] List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Jun 2003 09:12:06 -0000 On Sun, 2003-06-22 at 22:26, Paul Gelderblom wrote: > > The patch file included is a context diff against the current head > revision in the freebsd repository. Cool, unidiffs would be even better :) > Ville: It's a relatively small change so I hope it can be included > there .... Thanks, it looks mostly good, but a couple of remarks: - } elsif (/^head:\s+([\d\.]+)/) { + } + if (/^head:\s+([\d\.]+)/) { That hunk in readLog() would change the existing behaviour, I've changed it into: $symrev{$1} = $2; + next; } else { $symnames = 0; } - } elsif (/^head:\s+([\d\.]+)/) { + } + if (/^head:\s+([\d\.]+)/) { I also opened your .gif in Gimp and just saved it again to save almost 800 bytes :) BTW, it looks like the list ate some of your attachments but the Cc: to me worked just fine. Cheers, -- \/ille Skyttä scop at FreeBSD.org