From owner-freebsd-bugs  Sun May  7  1:30: 4 2000
Delivered-To: freebsd-bugs@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.ORG [204.216.27.21])
	by hub.freebsd.org (Postfix) with ESMTP id 1F52A37BA26
	for <freebsd-bugs@FreeBSD.org>; Sun,  7 May 2000 01:30:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id BAA66393;
	Sun, 7 May 2000 01:30:00 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from oxygen.yy.ics.keio.ac.jp (oxygen.yy.ics.keio.ac.jp [131.113.47.3])
	by hub.freebsd.org (Postfix) with ESMTP
	id EA41237B6AA; Sun,  7 May 2000 01:24:49 -0700 (PDT)
	(envelope-from sanpei@sanpei.org)
Received: from lavender.yy.cs.keio.ac.jp (ppp130.dialup.st.keio.ac.jp [131.113.27.130])
	by oxygen.yy.ics.keio.ac.jp (8.9.3+3.2W/3.7W) with ESMTP id RAA03711;
	Sun, 7 May 2000 17:24:46 +0900 (JST)
	(envelope-from sanpei@sanpei.org)
Received: (from sanpei@localhost)
	by lavender.yy.cs.keio.ac.jp (8.9.3/3.7W) id RAA02248;
	Sun, 7 May 2000 17:24:47 +0900 (JST)
Message-Id: <200005070824.RAA02248@lavender.yy.cs.keio.ac.jp>
Date: Sun, 7 May 2000 17:24:47 +0900 (JST)
From: sanpei@sanpei.org
Reply-To: sanpei@sanpei.org
To: FreeBSD-gnats-submit@freebsd.org
Cc: imp@FreeBSD.org
X-Send-Pr-Version: 3.2
Subject: i386/18431: [Patch] always probe and attach sn driver on isa bus without card.
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         18431
>Category:       i386
>Synopsis:       [Patch] always probe and attach sn driver
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun May 07 01:30:00 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     MIHIRA Yoshiro
>Release:        FreeBSD 5.0-CURRENT i386
>Organization:
Yokohama, Japan.
>Environment:


>Description:

  With GENERIC kernel, if I don't have any sn ethernet card on isa bus,
sn device was always attached like this.

sn0 at port 0x300-0x30f irq 10 on isa0

  Because, if_sn_isa.c has bug(I think we could never probe sn driver
on isa bus....)

I hope to fix this problem.

Cheers

>How-To-Repeat:


>Fix:

--- sys/dev/sn/if_sn_isa.c.org	Sun May  7 11:51:03 2000
+++ sys/dev/sn/if_sn_isa.c	Sun May  7 11:50:40 2000
@@ -63,8 +63,8 @@
 	if (isa_get_logicalid(dev))		/* skip PnP probes */
 		return (ENXIO);
 	if (sn_probe(dev, 0) != 0)
-		return (0);
-	return (ENXIO);
+		return (ENXIO);
+	return (0);
 }
 
 static int

>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message