From owner-freebsd-ports@FreeBSD.ORG Fri Aug 19 21:50:59 2011 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 90F811065672; Fri, 19 Aug 2011 21:50:59 +0000 (UTC) (envelope-from perryh@pluto.rain.com) Received: from agora.rdrop.com (agora.rdrop.com [IPv6:2607:f678:1010::34]) by mx1.freebsd.org (Postfix) with ESMTP id 70F268FC0A; Fri, 19 Aug 2011 21:50:59 +0000 (UTC) Received: from agora.rdrop.com (66@localhost [127.0.0.1]) by agora.rdrop.com (8.13.1/8.12.7) with ESMTP id p7JLowP2030121 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 19 Aug 2011 14:50:58 -0700 (PDT) (envelope-from perryh@pluto.rain.com) Received: (from uucp@localhost) by agora.rdrop.com (8.13.1/8.12.9/Submit) with UUCP id p7JLowaY030120; Fri, 19 Aug 2011 14:50:58 -0700 (PDT) Received: from fbsd81 ([192.168.200.81]) by pluto.rain.com (4.1/SMI-4.1-pluto-M2060407) id AA15715; Fri, 19 Aug 11 14:47:53 PDT Date: Fri, 19 Aug 2011 21:47:33 -0700 From: perryh@pluto.rain.com To: utisoft@gmail.com Message-Id: <4e4f3c65.SWjpvhhzZjBepdJu%perryh@pluto.rain.com> References: <201108171436.p7HEaNYQ071778@fire.js.berklix.net> <20110817161554.GA2496@lonesome.com> <4e4cc750.GqJImeHzdv6k8zld%perryh@pluto.rain.com> <4E4CBBEE.4040302@FreeBSD.org> In-Reply-To: User-Agent: nail 11.25 7/29/05 Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: mandree@freebsd.org, freebsd-ports@freebsd.org Subject: Re: sysutils/diskcheckd needs fixing and a maintainer X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Aug 2011 21:50:59 -0000 Chris Rees wrote: > On 18 Aug 2011 08:15, "Matthias Andree" wrote: > > Am 18.08.2011 08:20, schrieb Chris Rees: > > > On 18 August 2011 09:03, wrote: > > >> Chris Rees wrote: > > >> > > >>> We don't want to provide broken software. > > >> > > >> Mark Linimon wrote: > > >> > > >>> ... it's obsolete, broken, junk ... > > >> > > >> Unless there is more to this than is reported in those two > > >> PRs, I'd call it a considerable exaggeration to describe > > >> diskcheckd as "broken". > > >> > > >> * http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/115853 > > >> is shown as "closed", so presumably is no longer a problem. > > > > > > Wow, would it have been too difficult to actually READ the > > > closing message from Jeremy? I suggest you look again -- I've > > > pasted it here so you can see it. > > > > > > "The problem here is that the code does not do what the > > > manpage says (or vice-versa). The 3rd column does not specify > > > frequency of checking, but rather, over what duration of time > > > to spread a single disk scan over. Thus, 7 days would mean > > > "spread the entire disk check at X rate over the course of 7 > > > days" ... I'm closing the PR because trying to fix all of this > > > should really be ben@'s responsibility ... > > > > > > How does that indicate it's fixed? It's an 'abandoned' PR. If it's OK to close a PR without fixing it, because no one seems interested, maybe we should just close 143566 and be done with it :>-> The only "problem" I can see WRT 115853 is that someone misread the manpage. To me, it is clear that diskcheckd provides two _alternative_ ways of specifying how much bandwidth it should consume: diskcheckd.conf specifies either a length of time over which to spread each pass, or an average data rate. In either case it runs continuously, not intermittently. How else should one interpret the sentence "Naturally, it would be contradictory to specify both the frequency and the rate, so only one of these should be specified."? So it is correct that 115853 is "closed", because it wasn't valid in the first place. The program works as designed. > ... Let's get this straight, I was not 'attracting attention', > I was saying 'I'm going to remove this port; it's been broken > for over a year.' ... which might be justifiable, if it were in fact broken, but AFAICT it is not. I've been running it for a little less than two days now, on a drive which contains a gmirror, and have yet to see it misbehave. (The HDD indicator does stay on, but this is not surprising given that, as noted above, diskcheckd is expected to run continuously.) > > Do we need a "think twice before adding a port" habit? > > Yes. Of course, these aren't pointless ports however; while > still developed and maintained they were once useful. IIUC, diskcheckd started out in base and was later moved to ports (for reasons that are not obvious). I can't see that it is any less useful now than when first developed, or when moved from base to ports. > It's time to go when they break and bitrot. For some definition of "break and bitrot." Again, I haven't seen any actual breakage. diskcheckd could use a little tweaking, e.g. diskcheckd.conf.sample contains a stale reference to "the diskcheckd.conf(5) manual page" which was presumably missed when diskcheckd was moved to ports; it should now be "the diskcheckd(8) manual page". BTW how does one go about fixing a FreeBSD-native port like this? Since we are the upstream, it would make more sense to revise the distfile than to add a patch in the port. I didn't find any mention of this in the Porter's Handbook.