From owner-svn-ports-all@FreeBSD.ORG  Fri Jun 21 07:38:19 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 978E0FB6; Fri, 21 Jun 2013 07:38:19 +0000 (UTC)
Date: Fri, 21 Jun 2013 07:38:19 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Jason Helfman <jgh@FreeBSD.org>
Subject: Re: svn commit: r321445 - head/mail/gnarwl
Message-ID: <20130621073819.GA1394@FreeBSD.org>
References: <201306210619.r5L6JY12055282@svn.freebsd.org>
 <CAMuy=+j0FvdUx86RF9MX6-HBRXzvpwDtK8xuWkyG+yJxo3-VaA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAMuy=+j0FvdUx86RF9MX6-HBRXzvpwDtK8xuWkyG+yJxo3-VaA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>,
 Antoine Brodin <antoine@freebsd.org>,
 "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>,
 "ports-committers@freebsd.org" <ports-committers@freebsd.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 21 Jun 2013 07:38:19 -0000

On Thu, Jun 20, 2013 at 11:23:05PM -0700, Jason Helfman wrote:
> > @@ -18,7 +18,7 @@ USE_GMAKE=    yes
> >  USES=          iconv
> >  USE_OPENLDAP=  yes
> >  GNU_CONFIGURE= yes
> > -CONFIGURE_ARGS+=--with-docdir=${DOCSDIR}
> > +CONFIGURE_ARGS=        --with-docdir=${DOCSDIR}
> >
> >  MAN8=          damnit.8 gnarwl.8
> >  MANCOMPRESSED= yes
> 
> It may look more pretty, but in the end your original commit didn't clobber
> any pre-existing CONFIGURE_ARGS that may have been set by the user. This
> one does.

We never supported preset (users) CONFIGURE_ARGS, and it would be silly
thing if we did (contrary to CC/CFLAGS).  There is an umpteen number of
configure scripts out there, both coming from different, often incompatible
versions of autotools or written manually, and handling any CONFIGURE_ARGS
in /etc/make.conf would likely break a lot of ports.  User is not supposed
to mess with them on that global level.

It's maintainer's duty to ensure that port provides appropriate configure
arguments; if user is smart/brave enough to change them, we must assume
that we knows what he's doing, and can edit Makefile directly.  That said,
CONFIGURE_ARGS= is correct here.

./danfe