From nobody Sat Oct 11 12:03:57 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ckMht2nBLz6BlbN; Sat, 11 Oct 2025 12:03:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ckMhs31kBz3r4d; Sat, 11 Oct 2025 12:03:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760184237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MIZSW03uWd2LfI9sXBkwE1SQxbTfpBSeIBLuIu4Hsqo=; b=WxhFwKE/VM2cH7mkFQQ6Gg6cioDptS0qLnEVjolfnyr+zrnSovxAWRLcpeiU+7yN+0AKL4 7ZSmasDnzoOwTeMKNuuSJuj2fNofDQKPLzEDmcibVapAGtCyb6mBPMTbWcY6cwqsdmUVTG ZTSrVuQcLCBLuVglMYwevpH7FtA/xKMkE8y7vyPlbDJJO5TGM0xDIVceUqtQ4vC5AnaNaI gnOIYxtHOVZ5iYetpHdmwS1sMpHTgeBgBPRdS57JdfJ+hGdb1FuouhMz7Xq97tPlt1Cgb+ QAFdj5g6z3fdpkLVz70jR91cJJu+DhIbwfMLvKi8pBsNIWYsL9LNzU0dD6OdWg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1760184237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MIZSW03uWd2LfI9sXBkwE1SQxbTfpBSeIBLuIu4Hsqo=; b=yqUA2dnaVDu9DvAuxyCFzLVqq/NJ9DJ0snjSHJ7JlvO5Ga0XipPHvJBj+24U3F5kMnp4oB JrSt81/IHLdl03H2fPSLHW2gMCT4HtWgJBcnXo6Ag1f4LJDxte0OZ3HZC+/ZmtlhHqQvyA S8XqlkmG1KaMAKU5uTbvWqw8RCO+PlmfGZP9VHkNS+jp2iglkTks3djK+fI4aV917y2w5e mdh1CLUw8L/pAJ8S9QEHexIUQvwG7i4i1e1eLk9qmzeMJMbpst+9EEB91Locft5twq0RHN rLDH8U2Uqp/9sQN9fS4CaefueAX1wRH2SuJ8vBmnhP1ZjT2kuO1uh+qQga9NLw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1760184237; a=rsa-sha256; cv=none; b=WFbtNOcC0P7RQr0PF8HK7yi6COCw0R9JbiudaLMiJ/5wRA0i7+akpJPcJun/Dz1VSdNN27 TLoNXDmg5M+1aZe/hc2FV0yCkUBwS6/nmG8Hs/SsLlY1LC8nDBbRoGt7xGRbcvXSj8lmXv zX0g2CFJa1FGYYn0P1R086IBPHTjy4cMhCCt+msc3TI4f6XvgLAIaCohGGAM5v/Z/9SGzg jkIglaUvfV0xC2AubpOyfnSXilAdzyW2MmLClbaIVPQ1JkbMUt7JM7ojV8KeUjqihN9IHq fgojcIckIyJ0ce5f2USY2S2/NEQP/R69LutcUZTyP1AwT2rM4MmL0J38Fpr9ug== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ckMhs2Vl9zZdc; Sat, 11 Oct 2025 12:03:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 59BC3vio040084; Sat, 11 Oct 2025 12:03:57 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 59BC3vE3040081; Sat, 11 Oct 2025 12:03:57 GMT (envelope-from git) Date: Sat, 11 Oct 2025 12:03:57 GMT Message-Id: <202510111203.59BC3vE3040081@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 8a6bfa0455bf - main - pf tests: add missing atf_test_case lines for nat tests List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8a6bfa0455bfd4b77cb71d229b9dfca031b6703f Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=8a6bfa0455bfd4b77cb71d229b9dfca031b6703f commit 8a6bfa0455bfd4b77cb71d229b9dfca031b6703f Author: Kristof Provost AuthorDate: 2025-10-10 15:12:36 +0000 Commit: Kristof Provost CommitDate: 2025-10-11 11:24:25 +0000 pf tests: add missing atf_test_case lines for nat tests The lack of these lines means we don't call the cleanup function. That's not as bad as it could be, because these tests are nested in a jail by Kyua, so most of the cleanup work (destroying jails and interfaces) is done when the parent jail goes away, but it's still better to have these lines. Sponsored by: Rubicon Communications, LLC ("Netgate") --- tests/sys/netpfil/pf/nat.sh | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/sys/netpfil/pf/nat.sh b/tests/sys/netpfil/pf/nat.sh index e55f46418221..63658164c1fe 100644 --- a/tests/sys/netpfil/pf/nat.sh +++ b/tests/sys/netpfil/pf/nat.sh @@ -474,6 +474,7 @@ no_addrs_random_cleanup() pft_cleanup } +atf_test_case "nat_pass" "cleanup" nat_pass_head() { atf_set descr 'IPv4 NAT on pass rule' @@ -505,6 +506,7 @@ nat_pass_cleanup() pft_cleanup } +atf_test_case "nat_match" "cleanup" nat_match_head() { atf_set descr 'IPv4 NAT on match rule' @@ -644,6 +646,7 @@ map_e_pass_cleanup() pft_cleanup } +atf_test_case "binat_compat" "cleanup" binat_compat_head() { atf_set descr 'IPv4 BINAT with nat ruleset' @@ -710,6 +713,7 @@ binat_compat_cleanup() kill $(cat ${PWD}/inetd_tester.pid) } +atf_test_case "binat_match" "cleanup" binat_match_head() { atf_set descr 'IPv4 BINAT with nat ruleset'