From owner-svn-ports-head@FreeBSD.ORG Thu Apr 10 10:26:44 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1A84F701; Thu, 10 Apr 2014 10:26:44 +0000 (UTC) Received: from mail-wg0-x22b.google.com (mail-wg0-x22b.google.com [IPv6:2a00:1450:400c:c00::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0D4B91088; Thu, 10 Apr 2014 10:26:42 +0000 (UTC) Received: by mail-wg0-f43.google.com with SMTP id x13so3775830wgg.14 for ; Thu, 10 Apr 2014 03:26:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=3pD/0WGetmo1ZUEWoOI34EM5yOcPimhgCCKKgrCCCbs=; b=dPu1FnEFc3dcdtaPb+0PpreK0/5lcvvAmnS2Tfi3scpf3/pzrkuWlMM4bWV4Dfo7hM pxq2rwmwR9FW4UQvq3ZkPu6A0PMZKX47/PYGK014Z1eqejTJkaNxVAcKG4uuOSkapoHd HM5QJ/PC2M5Nlh5G8hB3YrwaLm8KzijkFzmPVECYrYzwkQK7o5bxdGYKjj0xIgInIlwg 8UjjFLvDp649g11bv7MLrDTm9ZMvo1VN7ieMovexp6XRmGDPfCL1E5b7mNE8Q8BJlLMz si+Z//hvz3ebBXQmjDbKj7dj31w3uawUijovt0TpGS2pBS2fHT4mGjtlpYI7jcQ4YPbt aocw== X-Received: by 10.180.24.72 with SMTP id s8mr41801515wif.20.1397125601257; Thu, 10 Apr 2014 03:26:41 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id n5sm10151625wiz.1.2014.04.10.03.26.39 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 10 Apr 2014 03:26:40 -0700 (PDT) Sender: Baptiste Daroussin Date: Thu, 10 Apr 2014 12:26:38 +0200 From: Baptiste Daroussin To: =?utf-8?B?UGF3ZcWCIFDEmWthbGE=?= Subject: Re: svn commit: r350792 - head/emulators/tme Message-ID: <20140410102638.GE8207@ivaldir.etoilebsd.net> References: <201404100911.s3A9B8BV042081@svn.freebsd.org> <20140410094640.GB8207@ivaldir.etoilebsd.net> <20140410121133.000066f7@freebsd.org> <20140410101619.GD8207@ivaldir.etoilebsd.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="mR8QP4gmHujQHb1c" Content-Disposition: inline In-Reply-To: <20140410101619.GD8207@ivaldir.etoilebsd.net> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: Mathieu Arnold , svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Apr 2014 10:26:44 -0000 --mR8QP4gmHujQHb1c Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 10, 2014 at 12:16:19PM +0200, Baptiste Daroussin wrote: > On Thu, Apr 10, 2014 at 12:11:33PM +0200, Pawe=C5=82 P=C4=99kala wrote: > > Baptiste Daroussin wrote: > >=20 > > > On Thu, Apr 10, 2014 at 11:39:45AM +0200, Mathieu Arnold wrote: > > > > +--On 10 avril 2014 09:11:08 +0000 Pawel Pekala > > > > wrote: | - Remove some dependencies pulled in automatically by > > > > others > > > >=20 > > > > Ah, that feels wrong, a port should have explicit dependencies to > > > > thing it needs to fetch/extract/build/link/run, it should not rely > > > > on some of its dependencies bringing what it needs as sub > > > > dependencies. > > > >=20 > > > Good catch I haven't seen that one > > >=20 > > > This is wrong because the day one of the deps stop pulling down a > > > dependency of this port then this port will be broken > >=20 > > All removed dependencies libraries can be found in pkg -B gtk2 output, > > which is build and run dependency (USES=3D gtk20) so I don't see any > > problem here except not clear log entry. > >=20 >=20 > The day gtk20 does not depends anymore on this you are doomed if those de= ps are > explicitly depended on by your port >=20 With a bit more of precision: 90% of the one you removed can safely be remo= ved because for sure they are not directly used by tme but exposed via gtk20 in= that case it is safe to remove them. I'm not that sure about pcre or expat for e= xample In the end to know what should be explicitly listed the right things is on freebsd 10 to look at the pkg info -B tme and only list the dependencies sh= own here. Why FreeBSD 10+ ? because on earlier version or freebsd ld(1) overlink. Even there, it won't be 100% accurate because gtk pc files it known to be respon= sible of a bit of overlinking and the way we use libtool in the ports tree is also responsible of a bit of overlinking (in particular the fast that we do keep= .la files) Anyway anything not shown by pkg info -B tme on FreeBSD 10+ can safely be removed :) (Honnestly I think in the tme case in particular you are safe after a secon= d review) regards, Bapt --mR8QP4gmHujQHb1c Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlNGcd4ACgkQ8kTtMUmk6EyWPQCeM/jePG/HRChh2Al7IkAXl5Ci r+4AoLB0ZD+1vB7cAh7CYyn4dEGQjc8v =gZMw -----END PGP SIGNATURE----- --mR8QP4gmHujQHb1c--