From owner-dev-commits-src-branches@freebsd.org  Mon Feb  1 13:56:00 2021
Return-Path: <owner-dev-commits-src-branches@freebsd.org>
Delivered-To: dev-commits-src-branches@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0638152A772
 for <dev-commits-src-branches@mailman.nyi.freebsd.org>;
 Mon,  1 Feb 2021 13:56:00 +0000 (UTC)
 (envelope-from jrtc27@jrtc27.com)
Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com
 [209.85.128.51])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (2048 bits) client-digest SHA256)
 (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4DTqGl6XTzz3RDQ
 for <dev-commits-src-branches@freebsd.org>;
 Mon,  1 Feb 2021 13:55:59 +0000 (UTC)
 (envelope-from jrtc27@jrtc27.com)
Received: by mail-wm1-f51.google.com with SMTP id u14so12716405wml.4
 for <dev-commits-src-branches@freebsd.org>;
 Mon, 01 Feb 2021 05:55:59 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc
 :content-transfer-encoding:message-id:references:to;
 bh=R8/6DAYD7FaIAfNhFbxziww5jJQWPAUE5ZPZA3Kxl+Y=;
 b=ZWBKb2bml1clGdmzFQYfPFUJ+Eeqh2G6QDyCA2DgskE+f5snBKv+m88TQwRf3/ilXI
 HpKlY/yYuSELjmAbiKRRoSu/bMLrNCiwZXVF5Ed4KSJ3JywtXeLivEKioPE/jcnW7Dtc
 XYS4KuKkk/1jAFPQXQN0zxhdz27jlLObyQzYLxeppLNXyTuSc4B3UPXzA3F2MHI29ij0
 ph6mx2VL56vUsppKNzEz5v8YQkxJeK3/BMWpPCpy4kf+im+zIywbDgQxwStVxIOT2WFZ
 Xy8jaWGakpuyhrSW25W9GrovK2gRqrjNxlhxyDL83vzicPyoJHemBNvTUCYIoR6EPZQS
 fvCQ==
X-Gm-Message-State: AOAM532by41UbPO7UFwHjnoV52WP14NlHWi2lJT4SJFjBepGM4VWkHD4
 n1DbXZzsqwfVH0W9+ZrXHR3PyA==
X-Google-Smtp-Source: ABdhPJxGQ6h1Qng+YU28tNu8Jc35IsYv7ZJEa+RUSbFFf8i14eeC+gshJcRIfbgW9yLhOpn9MxKMJA==
X-Received: by 2002:a1c:7d0c:: with SMTP id y12mr15172647wmc.184.1612187758125; 
 Mon, 01 Feb 2021 05:55:58 -0800 (PST)
Received: from [192.168.149.251] (trinity-students-nat.trin.cam.ac.uk.
 [131.111.193.104])
 by smtp.gmail.com with ESMTPSA id b132sm21194988wmh.21.2021.02.01.05.55.57
 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 01 Feb 2021 05:55:57 -0800 (PST)
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
Subject: Re: git: fc301c224b27 - stable/13 - atomic: add stub
 atomic_load_consume_ptr
From: Jessica Clarke <jrtc27@freebsd.org>
In-Reply-To: <84f152e1-b1ed-b331-ab45-261dd3996903@selasky.org>
Date: Mon, 1 Feb 2021 13:55:55 +0000
Cc: Mateusz Guzik <mjg@FreeBSD.org>,
 "src-committers@freebsd.org" <src-committers@FreeBSD.org>,
 "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>,
 "dev-commits-src-branches@freebsd.org" <dev-commits-src-branches@FreeBSD.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <E51C75A1-D7EF-4D5E-98E9-7857AFDDB7AC@freebsd.org>
References: <202102011240.111CeiX9094867@gitrepo.freebsd.org>
 <84f152e1-b1ed-b331-ab45-261dd3996903@selasky.org>
To: Hans Petter Selasky <hps@selasky.org>
X-Mailer: Apple Mail (2.3608.120.23.2.4)
X-Rspamd-Queue-Id: 4DTqGl6XTzz3RDQ
X-Spamd-Bar: ----
Authentication-Results: mx1.freebsd.org;
	none
X-Spamd-Result: default: False [-4.00 / 15.00];
	 REPLY(-4.00)[]
X-BeenThere: dev-commits-src-branches@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: Commits to the stable branches of the FreeBSD src repository
 <dev-commits-src-branches.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/dev-commits-src-branches>, 
 <mailto:dev-commits-src-branches-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/dev-commits-src-branches/>
List-Post: <mailto:dev-commits-src-branches@freebsd.org>
List-Help: <mailto:dev-commits-src-branches-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/dev-commits-src-branches>, 
 <mailto:dev-commits-src-branches-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 01 Feb 2021 13:56:00 -0000

On 1 Feb 2021, at 13:53, Hans Petter Selasky <hps@selasky.org> wrote:
> On 2/1/21 1:40 PM, Mateusz Guzik wrote:
>> +/*
>> + * Currently all architectures provide acquire and release fences on =
their own,
>> + * but they don't provide consume. Kludge below allows relevant code =
to stop
>> + * openly resorting to the stronger acquire fence, to be sorted out.
>> + */
>> +#define	atomic_load_consume_ptr(p)	\
>> +    ((__typeof(*p)) atomic_load_acq_ptr((uintptr_t *)p))
>> +
>=20
> Are you missing:
>=20
> CTASSERT(sizeof(*p) =3D=3D sizeof(void *)) ????

I also commented on the head commit that this is a waste of time and
will likely never be anything other than an acquire, but never got a
reply.

Jess