From owner-freebsd-current@FreeBSD.ORG  Tue Sep 24 11:00:55 2013
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 22D9B8D1;
 Tue, 24 Sep 2013 11:00:55 +0000 (UTC)
 (envelope-from pluknet@gmail.com)
Received: from mail-wg0-x22f.google.com (mail-wg0-x22f.google.com
 [IPv6:2a00:1450:400c:c00::22f])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 8E61D235B;
 Tue, 24 Sep 2013 11:00:54 +0000 (UTC)
Received: by mail-wg0-f47.google.com with SMTP id f12so4301734wgh.26
 for <multiple recipients>; Tue, 24 Sep 2013 04:00:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:in-reply-to:references:date:message-id:subject:from:to
 :cc:content-type;
 bh=oAmpGjd0Sw8JUPSaCzgd8nTsfsQPJ0x8kiZkoYTUSg0=;
 b=RpXCgWtyBKP5+zSBoCgSVS1K3xY7R0Juw6zthDdKJ0fJhBaeJJaZ9UA+4HZW+/FSmA
 RdM7yTC0weVTh70ttLH07nji+BRXqLI6topno/NoH6PpaIXDjqUXxYvtCak9Tpt04+jt
 zjB48YC+AJk0eFv3S7HGzYYzZfYnsOAvmk7Dgazd4qs3zJTHaQzA5iNaT9vSrvYXJYQ5
 vttJs77xd9P+Z/ctykO6Bz0UdzagMKJyzA4SILl+gLU3t4u6GUy6ApcQJvN93lkcNf/y
 Ydm5PiZCe/fKz41POevocbX4sfLGyMVAMDT1J5rE7jSLJ82JmOVrVVGZmjl1dQ+qFjL8
 yRWg==
MIME-Version: 1.0
X-Received: by 10.180.206.42 with SMTP id ll10mr17637555wic.50.1380020453089; 
 Tue, 24 Sep 2013 04:00:53 -0700 (PDT)
Received: by 10.216.62.5 with HTTP; Tue, 24 Sep 2013 04:00:53 -0700 (PDT)
In-Reply-To: <CAE-mSO+fWdySa+O6kuSe-z9AQsi0TNFy7LMrgx-btUJfQhx=jw@mail.gmail.com>
References: <20130924104658.46313090@laptop.minsk.domain>
 <CAE-mSO+fWdySa+O6kuSe-z9AQsi0TNFy7LMrgx-btUJfQhx=jw@mail.gmail.com>
Date: Tue, 24 Sep 2013 15:00:53 +0400
Message-ID: <CAE-mSOKpNMV9PWR-Z2geS889aSbaBiTZavdDmvaxwx6U4_7EPw@mail.gmail.com>
Subject: Re: panic: make_dev_credv: bad si_name (error=17, si_name=iscsi)
From: Sergey Kandaurov <pluknet@gmail.com>
To: "Sergey V. Dyatko" <sergey.dyatko@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Cc: =?ISO-8859-2?Q?Edward_Tomasz_Napiera=B3a?= <trasz@freebsd.org>,
 current <current@freebsd.org>
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Sep 2013 11:00:55 -0000

On 24 September 2013 14:40, Sergey Kandaurov <pluknet@gmail.com> wrote:
> On 24 September 2013 11:46, Sergey V. Dyatko <sergey.dyatko@gmail.com> wrote:
>> Hi,
>>
>> today I tried to play a bit with new iscsi
>>
>> r255812 isn't fully complete fix?
>>
> [...]
>> run  `kldload iscsi_initiator` and got a panic:
>
> Something like this quick'n'dirty should work.
> Compile tested only.
>
> Index: sys/dev/iscsi_initiator/iscsi.c
> ===================================================================
> --- sys/dev/iscsi_initiator/iscsi.c    (revision 255841)
> +++ sys/dev/iscsi_initiator/iscsi.c    (working copy)
> @@ -715,7 +715,8 @@
>       TUNABLE_INT_FETCH("net.iscsi_initiator.max_pdus", &max_pdus);
>
>       isc =  malloc(sizeof(struct isc_softc), M_ISCSI, M_ZERO|M_WAITOK);
> -     isc->dev = make_dev(&iscsi_cdevsw, max_sessions, UID_ROOT,
> GID_WHEEL, 0600, "iscsi");
> +     isc->dev = make_dev_credf(MAKEDEV_CHECKNAME, &iscsi_cdevsw, max_sessions,
> +                               NULL, UID_ROOT, GID_WHEEL, 0600, "iscsi");
>       isc->dev->si_drv1 = isc;
>       mtx_init(&isc->isc_mtx, "iscsi-isc", NULL, MTX_DEF);

Erm, of course it shall be checked against failure.

-- 
wbr,
pluknet