From nobody Tue Sep 2 18:40:53 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cGZLs3t41z679N6; Tue, 02 Sep 2025 18:40:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cGZLs3Cwcz3XtF; Tue, 02 Sep 2025 18:40:53 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756838453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tKvf6fT+pJs0Jp7cV70kx9yTcyv2iiW4nPIsQmeRRRg=; b=jaO0Ic8JFasYyPVLMbkEdAOe4Hm3WYencppAeo9/zmj/tXwgnHbHQwq5rFffi7qev2pFrH LGGN94ZD7AShL6u+PoiZrD5ojU/FVggrYIk6CcbbU6epCvJFyhJKJmZkIcNTZxSuNqAVAk /ktevXOksfk+NsuTyIVbQoQ0wzoTwTDYG/hhOR+hEfKbTnVbK63ni9CBfi9VLa7xJfD/RG 47M/4bvScPmWWgEpRcv00+TRM5Na7I9ahBFaCjYmeZWa8VgC/8cPv27BSsG6GsORGsXGw6 JVEx/ePFLQ0k+OZdg1yD3q7sAYvwsgh4QoZzyHjd/FlnXjjKuEh90A/+mejcKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1756838453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tKvf6fT+pJs0Jp7cV70kx9yTcyv2iiW4nPIsQmeRRRg=; b=Ebr8YIVRsijeJ63YCanmBoPcFmeJ5pjtz3v151M+3S5geZKxF/PkXN/yYcL5pPBgqmZ5SV zguJlX57FZ4cJX3/7h7FB2gOfiVMQQZzR+No2HNebk1rWC0N9u39PSyNW8IHpzdrsJU7SS quwaqJnWUoHK08a2hKEzvvu5yJFJYoB/zy1eC0W2m5KpTgunCQBDSwu7VPywJNcpbSg0ON VSxmIqzhMS21abzHFO3o37UnK2SnQhRRcy7EWsHxdcAXVQfb5cgJ19i+cMAZslthpoly0p si8/b671kMhVyHLJbOtuUIbQxwnifVNBf3xlUejz5fn/nQmaNVmCj7yMQnOPfg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1756838453; a=rsa-sha256; cv=none; b=onJmlze/AopfaG2RNh5mKmOCvsL9snenZKd0qkj3MfVAYXlf/T460WMGgo6R4diRryZYBQ RSpDIl64+yp8dwDmR06S7JuVgs72GBCRDQ6WlRURS1Hbp7oziOlVkAapLvP+coplVOHc87 Ma29+Q27xymmaUbBihX2oMrpr9Bv21zxLsc5zyGeIQDKStV3HwhaewhcCmEnbr1C1goRZj iCAVeVocqCWKOCwgLLUAoT+5fCYAN7TSVIGR0JwTKAmSmvm42R+qIcC9cezg8YVziAKFrU U0AoRglNsjXvyieUEv5TEc0DHHS/QcfgIaddFO9vYq3t/wyp0d4fHiw7RyEHng== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cGZLs2WrVzy17; Tue, 02 Sep 2025 18:40:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 582IerQj051497; Tue, 2 Sep 2025 18:40:53 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 582Ier0M051494; Tue, 2 Sep 2025 18:40:53 GMT (envelope-from git) Date: Tue, 2 Sep 2025 18:40:53 GMT Message-Id: <202509021840.582Ier0M051494@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 164597439270 - main - ctld: Add missing initializers for several class members List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 16459743927068abbee34ce3f266b38c71968232 Auto-Submitted: auto-generated The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=16459743927068abbee34ce3f266b38c71968232 commit 16459743927068abbee34ce3f266b38c71968232 Author: John Baldwin AuthorDate: 2025-09-02 18:40:30 +0000 Commit: John Baldwin CommitDate: 2025-09-02 18:40:30 +0000 ctld: Add missing initializers for several class members These fields all need to be explicitly initialized with zeroes. Prior to the conversion to C++ these fields were zeroed by calloc(). This worked for me in earlier testing as my test boxes had MALLOC_PRODUCTION enabled in make.conf. PR: 289115 Reported by: Slawa Olhovchenkov Fixes: eb0dc901a541 ("ctld: Convert struct auth_group to a C++ class") Fixes: 6acc7afa34aa ("ctld: Convert struct port to a hierarchy of C++ classes") Fixes: 2bb9180bb5d0 ("ctld: Convert struct target to a C++ class") Fixes: ed076901ec80 ("ctld: Convert struct ctld_connection to a C++ class") Sponsored by: Chelsio Communications --- usr.sbin/ctld/ctld.hh | 6 +++--- usr.sbin/ctld/iscsi.hh | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/usr.sbin/ctld/ctld.hh b/usr.sbin/ctld/ctld.hh index bfe4507bb3e6..cc88e6eb590e 100644 --- a/usr.sbin/ctld/ctld.hh +++ b/usr.sbin/ctld/ctld.hh @@ -425,7 +425,7 @@ protected: virtual struct portal_group *default_portal_group() = 0; struct conf *t_conf; - std::array t_luns; + std::array t_luns = {}; auth_group_sp t_auth_group; std::list t_ports; std::string t_name; @@ -434,7 +434,7 @@ protected: std::string t_redirection; /* Name of this target's physical port, if any, i.e. "isp0" */ std::string t_pport; - bool t_private_auth; + bool t_private_auth = false; }; using target_up = std::unique_ptr; @@ -575,7 +575,7 @@ struct pport { private: std::string pp_name; uint32_t pp_ctl_port; - bool pp_linked; + bool pp_linked = false; }; struct kports { diff --git a/usr.sbin/ctld/iscsi.hh b/usr.sbin/ctld/iscsi.hh index d510e8c6731b..66bfecd62692 100644 --- a/usr.sbin/ctld/iscsi.hh +++ b/usr.sbin/ctld/iscsi.hh @@ -66,7 +66,7 @@ private: std::string conn_initiator_name; std::string conn_initiator_addr; std::string conn_initiator_alias; - uint8_t conn_initiator_isid[6]; + uint8_t conn_initiator_isid[6] = {}; const struct sockaddr *conn_initiator_sa = nullptr; int conn_max_recv_data_segment_limit = 0; int conn_max_send_data_segment_limit = 0;