Date: Wed, 5 Feb 2014 12:15:25 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Tijl Coosemans <tijl@FreeBSD.org> Cc: svn-ports-head@freebsd.org, Koop Mast <kwm@FreeBSD.org>, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r342587 - head/x11/pixman Message-ID: <20140205121525.GB24764@FreeBSD.org> In-Reply-To: <20140204210959.044bc79a@kalimero.tijl.coosemans.org> References: <201402041839.s14IdgAF097754@svn.freebsd.org> <20140204210959.044bc79a@kalimero.tijl.coosemans.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 04, 2014 at 09:09:59PM +0100, Tijl Coosemans wrote:
> The is a bit strange because if you turn off SIMD you still get MMX and
> SSE2 support if your cpu supports it. It should be something like this:
>
> .if ! ${PORT_OPTIONS:MSIMD}
> CONFIGURE_ARGS= --disable-vmx --disable-arm-simd --disable-mmx \
> --disable-sse2
> .endif
>
> But then you're still missing --disable-ssse3 and a number of ARM and
> MIPS SIMD options (reported by ./configure --help).
>
> I think it's best to just remove this whole block together with the
> SIMD option because pixman tests at runtime what features the cpu
> supports so in my opinion there's no reason to disable SIMD support.
+1. I've always had to read inside the Makefile to understand what does
this option do; it's very confusing up-front. Please remove it and/or
hide the logic behind the trunk, so it DTRT without annoying users with
cryptic dialogs. Thank you. :)
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140205121525.GB24764>