From owner-freebsd-arch@FreeBSD.ORG  Wed Nov 16 18:39:14 2011
Return-Path: <owner-freebsd-arch@FreeBSD.ORG>
Delivered-To: freebsd-arch@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DE1B2106564A;
	Wed, 16 Nov 2011 18:39:14 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 8743E8FC08;
	Wed, 16 Nov 2011 18:39:14 +0000 (UTC)
Received: from [10.30.101.53] ([209.117.142.2]) (authenticated bits=0)
	by harmony.bsdimp.com (8.14.4/8.14.3) with ESMTP id pAGIWdJD001766
	(version=TLSv1/SSLv3 cipher=DHE-DSS-AES128-SHA bits=128 verify=NO);
	Wed, 16 Nov 2011 11:32:41 -0700 (MST) (envelope-from imp@bsdimp.com)
Mime-Version: 1.0 (Apple Message framework v1084)
Content-Type: text/plain; charset=us-ascii
From: Warner Losh <imp@bsdimp.com>
In-Reply-To: <CAOfDtXPX1Rv9T7+1jYQbkM14tRY7mqgCzPcUqvHxFaRObbwvEg@mail.gmail.com>
Date: Wed, 16 Nov 2011 11:32:27 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <B188597B-4446-4EAB-A9BD-D9EBBEB8B1D7@bsdimp.com>
References: <CAOfDtXPX1Rv9T7+1jYQbkM14tRY7mqgCzPcUqvHxFaRObbwvEg@mail.gmail.com>
To: Robert Millan <rmh@freebsd.org>
X-Mailer: Apple Mail (2.1084)
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1
	(harmony.bsdimp.com [10.0.0.6]);
	Wed, 16 Nov 2011 11:32:41 -0700 (MST)
Cc: Kostik Belousov <kostikbel@gmail.com>, Adrian Chadd <adrian@freebsd.org>,
	freebsd-current@freebsd.org, freebsd-arch@freebsd.org
Subject: Re: [PATCH] Detect GNU/kFreeBSD in user-visible kernel headers
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
	<mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Nov 2011 18:39:15 -0000

Hey Robert,

Thanks for jumping into this.  Sadly, it is a bit of a mess.  Many of =
the "multiple BSD flavor" support #ifdefs are actually quite stale by =
now, so they should be cleaned up.  That's not something you have to =
cope with, unless you want, but it colors my first reaction :)

My second reaction was why not have

#ifndef __FreeBSD_kernel__
#define __FreeBSD_kernel__ __FreeBSD__
#endif

in sys/param.h and then just change __FreeBSD__ to __FreeBSD_kernel__ in =
the headers that are affected?  But I'm not quite sure what effects that =
would have on your environment.

Thanks for considering the above modification.

Warner

On Nov 16, 2011, at 10:27 AM, Robert Millan wrote:

> Hi!
>=20
> Out of the kernel headers that are installed in /usr/include/ =
hierracy, there
> are some which include support multiple operating systems (usually =
FreeBSD and
> other *BSD flavours).
>=20
> This patch adds support to detect GNU/kFreeBSD as well.  In all cases, =
we
> match the same declarations as FreeBSD does (which is to be expected =
in kernel
> headers, since both systems share the same kernel).
>=20
> Does it look fine?
> =
<gnu-kfreebsd_headers.diff>_______________________________________________=

> freebsd-arch@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-arch
> To unsubscribe, send any mail to =
"freebsd-arch-unsubscribe@freebsd.org"