From owner-freebsd-stable@freebsd.org Sat Jan 16 13:42:35 2016 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BE3E5A84CD9 for ; Sat, 16 Jan 2016 13:42:35 +0000 (UTC) (envelope-from 000.fbsd@quip.cz) Received: from elsa.codelab.cz (elsa.codelab.cz [94.124.105.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 839F21CBE for ; Sat, 16 Jan 2016 13:42:35 +0000 (UTC) (envelope-from 000.fbsd@quip.cz) Received: from elsa.codelab.cz (localhost [127.0.0.1]) by elsa.codelab.cz (Postfix) with ESMTP id 7194228429; Sat, 16 Jan 2016 14:42:33 +0100 (CET) Received: from illbsd.quip.test (ip-86-49-16-209.net.upcbroadband.cz [86.49.16.209]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by elsa.codelab.cz (Postfix) with ESMTPSA id 70B6E28428; Sat, 16 Jan 2016 14:42:32 +0100 (CET) Message-ID: <569A48C8.7080308@quip.cz> Date: Sat, 16 Jan 2016 14:42:32 +0100 From: Miroslav Lachman <000.fbsd@quip.cz> User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:35.0) Gecko/20100101 Firefox/35.0 SeaMonkey/2.32 MIME-Version: 1.0 To: Philippe Michel , freebsd-stable@freebsd.org Subject: Re: make installworld creates empty dirs which are deleted by make delete-old References: <569A4579.8010208@quip.cz> In-Reply-To: <569A4579.8010208@quip.cz> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Jan 2016 13:42:35 -0000 Miroslav Lachman wrote on 01/16/2016 14:28: > Philippe Michel wrote on 01/16/2016 13:51: >> On Sat, 16 Jan 2016, freebsd-stable-request@freebsd.org wrote: >> >>> I updated the server 3 times in one week (to 10.2-p8, -p9, -p10). >> >>> Those directories were deleted by delete-old >>> >>> # make -DBATCH_DELETE_OLD_FILES delete-old >>> >>> Removing old files (only deletes safe to delete libs) >>> >>> Old files removed >>> >>> Removing old directories >>> /usr/share/doc/atf >>> /usr/share/atf >>> /usr/include/atf-c++ >>> /usr/include/atf-c >>> >>> Old directories removed >>> To remove old libraries run 'make delete-old-libs'. >>> >>> By after next installworld, they are back. >> >> You build world WITHOUT_TESTS=true, don't you ? >> >> There are many of these flags that are somehow missed when creating >> directories at install. > > I don't use WITHOUT flags for buildworld / installwordl. The only > WITHOUT is one for kernel: > WITHOUT_KERNEL_SYMBOLS=yes [...] >> I think some similar cases were fixed a few months ago by NGie Cooper >> but it was apparently those he stumbled on by himself or some specific >> bug reports rather than the start of a more exhaustive sweep. >> >> I suppose opening a PR could have helped but I procrastinated :-(. > > OK, I will open PR for this today. > > Thank you for your suggestions. I found a half year old PR for this https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=201072 Miroslav Lachman