From owner-svn-src-all@freebsd.org Mon Oct 16 12:19:31 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D087FE3925C for ; Mon, 16 Oct 2017 12:19:31 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x22c.google.com (mail-io0-x22c.google.com [IPv6:2607:f8b0:4001:c06::22c]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 989EE7E46E for ; Mon, 16 Oct 2017 12:19:31 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x22c.google.com with SMTP id 101so15816637ioj.3 for ; Mon, 16 Oct 2017 05:19:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=8+8bLkronD++WYZmaLO+Qv2Ui8hI19lBPMlTT2eZVoY=; b=Z0jcseaUlUAoRVcnZYPwOmqD2KOcu8bstVTONocsNRT0rT/Dj2EbaQPmXfujIOq5dv nJkv8ngjn0SDBDdgxDcXEJNkUAZJVFmg2HYTRmaLNNwZQsyE53a8exZ14u0Jrtisrd2B r5Q/P3zR1WF5Rn1fhCc6hqiMOnwpxAmoQiQ22hNLUMK7AfBVuFQVnDWKXT9j0SRaeto/ e9rsKrDqlP+a0t1kfBl6lVi9ljykXbDi3OdhzGFOJdRcgTv7ijFOoZ2YCYiJtFlAdH3F WBwqsLEkQrJCYNEZmEwvbUOKSD8vk73VEAFQiOyCsLuv4CIt5/wWdwnRBWemdACGz8P8 KXYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=8+8bLkronD++WYZmaLO+Qv2Ui8hI19lBPMlTT2eZVoY=; b=Cu/Ah+YTLVP1ULsMPpKNobx2D1Jh48r3G/wksVxNE0zbTmeTroBEbIC2mlXalVdk5f PHPwEmjszmvNaD1JllRr33vZAWIRigMvEdIvorP1RmWnxTCR2sJf8Kg2tVnHBvZ7y/s3 2zRN9M74h6vJrLrUTMcyVbjNtFV99ydTUwfQYWVysbO3oLlD45ZNDx/oednSyvpsN3hx 2FgOJXTrmt3wTEp8fNBhuJReg9aUlJo/gwYijI1kXkGW+Rdi2CrVtUMikgTezSi9NE5Y WJjNR9CITIQzukDerELQvbuMVG/NC3DzHE2VyJztjuiCq9kCuGSGdEwKb0Fq9t+jjTbH BkEg== X-Gm-Message-State: AMCzsaW6R2Hc0/ks+QTcJDltoG+UkahHMXY6MU1NqKVK3OZusnFG6Wor gXYyO/ABrljuy0jTGyB0Nu/8sRmY8Prjp7AdWQY+pw== X-Google-Smtp-Source: ABhQp+QTBExTLmk9+mpRGT9Zsb5w6+rPkZvCbL8mb/cNjM9EqDB8CBLbe8/cplp96RKO3BYCh/jE4DSXHUJdLUxksIM= X-Received: by 10.107.187.2 with SMTP id l2mr10914353iof.136.1508156370790; Mon, 16 Oct 2017 05:19:30 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.94.130 with HTTP; Mon, 16 Oct 2017 05:19:29 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:5085:1a2f:dcb:9d2d] Received: by 10.79.94.130 with HTTP; Mon, 16 Oct 2017 05:19:29 -0700 (PDT) In-Reply-To: References: <201710160359.v9G3xCCi087576@repo.freebsd.org> From: Warner Losh Date: Mon, 16 Oct 2017 06:19:29 -0600 X-Google-Sender-Auth: -X_rQYPrgeyRAPJxMwREyDFV1s8 Message-ID: Subject: Re: svn commit: r324646 - in head/sys/boot/efi: boot1 libefi loader To: Andrew Turner , eric@meatspace.com Cc: src-committers , svn-src-head@freebsd.org, svn-src-all@freebsd.org, Warner Losh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Oct 2017 12:19:31 -0000 I'll take a look, but I've also ccd Eric so he can figure out what went wrong with is code in your environment. What env is That? Warnee On Oct 16, 2017 3:26 AM, "Andrew Turner" wrote: > > > On 16 Oct 2017, at 04:59, Warner Losh wrote: > > > > Author: imp > > Date: Mon Oct 16 03:59:11 2017 > > New Revision: 324646 > > URL: https://svnweb.freebsd.org/changeset/base/324646 > > > > Log: > > Unify boot1 with loader > > > > Refactor boot1 to use the same I/O code as /boot/loader uses. Refactor > > to use the common efi_main.c. > > > > Submitted by: Eric McCorkle > > Differential Revision: https://reviews.freebsd.org/D10447 > > > > Added: > > head/sys/boot/efi/libefi/efi_main.c (contents, props changed) > > - copied, changed from r324645, head/sys/boot/efi/loader/efi_main.c > > Deleted: > > head/sys/boot/efi/boot1/boot_module.h > > head/sys/boot/efi/boot1/ufs_module.c > > head/sys/boot/efi/boot1/zfs_module.c > > head/sys/boot/efi/loader/efi_main.c > > Modified: > > head/sys/boot/efi/boot1/Makefile > > head/sys/boot/efi/boot1/boot1.c > > head/sys/boot/efi/libefi/Makefile > > head/sys/boot/efi/loader/Makefile > > Hello Warner, > > After this change I=E2=80=99m getting the following panic on various test= VMs. > > Andrew > > >> FreeBSD EFI boot block > > Loader path: /boot/loader.efi > > Load Path: \EFI\BOOT\BOOTAA64.EFI > Load Device: VenHw(837DCA9E-E874-4D82-B29A- > 23FE0E23D1E2,003C000A00000000)/HD(1,GPT,DD40E9C6-B247-11E7- > AA0A-15EFE1BBB7CF,0x3,0x640) > panic: Couldn't trim device path > --> Press a key on the console to reboot <-- > >