Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 6 Oct 2020 08:18:10 +0000 (UTC)
From:      Baptiste Daroussin <bapt@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r366472 - head/usr.bin/backlight
Message-ID:  <202010060818.0968IABV016328@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: bapt
Date: Tue Oct  6 08:18:09 2020
New Revision: 366472
URL: https://svnweb.freebsd.org/changeset/base/366472

Log:
  backlight: check the lenght if the input before trimming '%'
  
  Reported by:	hps
  Reviewed by:	manu
  Differential Revision:	https://reviews.freebsd.org/D26693

Modified:
  head/usr.bin/backlight/backlight.c

Modified: head/usr.bin/backlight/backlight.c
==============================================================================
--- head/usr.bin/backlight/backlight.c	Tue Oct  6 08:05:19 2020	(r366471)
+++ head/usr.bin/backlight/backlight.c	Tue Oct  6 08:18:09 2020	(r366472)
@@ -145,7 +145,8 @@ main(int argc, char *argv[])
 
 		if (argc == 1) {
 			/* ignore a trailing % for user friendlyness */
-			if (argv[0][strlen(argv[0]) - 1] == '%')
+			if (strlen(argv[0]) > 0 &&
+			    argv[0][strlen(argv[0]) - 1] == '%')
 				argv[0][strlen(argv[0]) - 1] = '\0';
 			percent = strtonum(argv[0], 0, 100, &percent_error);
 			if (percent_error)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202010060818.0968IABV016328>