From owner-svn-src-all@freebsd.org Mon Aug 26 01:47:30 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 85CE2CB7E7 for ; Mon, 26 Aug 2019 01:47:30 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46GvyT3nwVz3F3V for ; Mon, 26 Aug 2019 01:47:29 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-qk1-x743.google.com with SMTP id d23so12951306qko.3 for ; Sun, 25 Aug 2019 18:47:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=paLFNFTL1CmTpZmLB+ClrikDf1/GDNOE0G8FbJVY6mw=; b=bQ+jwFX+39bTqg4daSD+bXXA1ZzJTfpv8Imoe3nhyHmxfBKNekpZNYhhyQ63UUeVnD WEL+Dd3qPLJt1zTKby4UYKh7B5EPkuqaegWaVNnHYBX1yfUrse7OKnn5M6I4LnH7FLUX bUD5iFDAqmYrPIcyFX1SN9ighoiLqSjCArZzInV9lh5+5gvbeXazRcStS5HDEPJC676M 9L7TNcrOR57vM1OdCAE2ovyQjosHrns5YggzT8IqSnm0ra+9tuperZC8tfiH0CgFUr1W stEqxa2WpiSNEQ1ra2PUYqZXCxKAw4mviMgETj0Ght9slPM9iC8RuzwSOLp+/zSvxchc P8Rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=paLFNFTL1CmTpZmLB+ClrikDf1/GDNOE0G8FbJVY6mw=; b=bc5XKZggYIN2MCcU4c0TZnqqVx2MSUQzv496vic+bIZWzAZ2C3Mra4CzRKND8RvPjM nrJOaS+UX8yQWs1Jglw0jfLXmi7lswpFSAr3MbZ6JSt7PHdC0d2NmaXqORbXCY5EEmiI qac9S/zgL0k6rXpUDZoVPZiZys06koMI3RzE1wT8PISkSvmD/LhDDp67T2cKQMzJhLn8 0fvuprVLfWURI/ZzXeLM8TjpM14YXgCNfM5ZucWnVofWboeYAEsCQyTSR/RnMYzyPEuC dx/3xNneSl2tAe4apAa8lX4e5ngYQheIf/tM38PfjOaEqyrVA7vDQ5WNEVb6V1IVcn7m QzaQ== X-Gm-Message-State: APjAAAWclWYKfeTDlkXmvU0Vp62gG1rcHV4ul3c9WIsLI4CwjtQ1NzaR zCCizQ/jjO3KWJoOaTtlyRtegQ== X-Google-Smtp-Source: APXvYqxtgJuNY3Aw1y3fMx39K6lYUBPh/dbxqRvYftJ+j89+n9f7e9hxmlUE3I9vcFrMUXkC9SmKGQ== X-Received: by 2002:a05:620a:4c8:: with SMTP id 8mr13402975qks.366.1566784048170; Sun, 25 Aug 2019 18:47:28 -0700 (PDT) Received: from mutt-hbsd ([151.196.118.239]) by smtp.gmail.com with ESMTPSA id q73sm5633433qke.90.2019.08.25.18.47.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Aug 2019 18:47:27 -0700 (PDT) Date: Sun, 25 Aug 2019 21:47:26 -0400 From: Shawn Webb To: Hiroki Sato Cc: asomers@FreeBSD.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r351423 - in head: . sbin/ping6 sbin/ping6/tests Message-ID: <20190826014726.mwddt4uwqoulewhh@mutt-hbsd> References: <201908231522.x7NFMLuJ068037@repo.freebsd.org> <20190826.042056.1329861772202588895.hrs@allbsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="63e6t6wtjncgu5iy" Content-Disposition: inline In-Reply-To: <20190826.042056.1329861772202588895.hrs@allbsd.org> X-Operating-System: FreeBSD mutt-hbsd 13.0-CURRENT-HBSD FreeBSD 13.0-CURRENT-HBSD X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0xFF2E67A277F8E1FA User-Agent: NeoMutt/20180716 X-Rspamd-Queue-Id: 46GvyT3nwVz3F3V X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=hardenedbsd.org header.s=google header.b=bQ+jwFX+; dmarc=none; spf=pass (mx1.freebsd.org: domain of shawn.webb@hardenedbsd.org designates 2607:f8b0:4864:20::743 as permitted sender) smtp.mailfrom=shawn.webb@hardenedbsd.org X-Spamd-Result: default: False [-5.54 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_DKIM_ALLOW(-0.20)[hardenedbsd.org:s=google]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-all@freebsd.org]; DMARC_NA(0.00)[hardenedbsd.org]; RCPT_COUNT_FIVE(0.00)[5]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[hardenedbsd.org:+]; NEURAL_HAM_SHORT(-0.97)[-0.973,0]; RCVD_IN_DNSWL_NONE(0.00)[3.4.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; MID_RHS_NOT_FQDN(0.50)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; RCVD_TLS_ALL(0.00)[]; IP_SCORE(-0.47)[ip: (2.91), ipnet: 2607:f8b0::/32(-2.87), asn: 15169(-2.33), country: US(-0.05)]; RECEIVED_SPAMHAUS_PBL(0.00)[239.118.196.151.khpj7ygk5idzvmvt5x4ziurxhy.zen.dq.spamhaus.net : 127.0.0.10] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Aug 2019 01:47:30 -0000 --63e6t6wtjncgu5iy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 26, 2019 at 04:20:56AM +0900, Hiroki Sato wrote: > Hi, >=20 > Alan Somers wrote > in <201908231522.x7NFMLuJ068037@repo.freebsd.org>: >=20 > as> Author: asomers > as> Date: Fri Aug 23 15:22:20 2019 > as> New Revision: 351423 > as> URL: https://svnweb.freebsd.org/changeset/base/351423 > as>=20 > as> Log: > as> ping6: Rename options for better consistency with ping > as> =20 > as> Now equivalent options have the same flags, and nonequivalent optio= ns have > as> different flags. This is a prelude to merging the two commands. > as> =20 > as> Submitted by: J?n Su?an > as> MFC: Never > as> Sponsored by: Google LLC (Google Summer of Code 2019) > as> Differential Revision: https://reviews.freebsd.org/D21345 >=20 > I have an objection on renaming the existing option flags in ping6(8) > for compatibility with ping(8). >=20 > Is it sufficient to add INET6 support to ping(8) with consistent > flags and keep CLI of ping6(8) backward compatible? People have used > ping6(8) for >15 years, so it is too late to rename the flags. I do > not think the renaming is useful if "ping -6 localhost" or "ping ::1" > works. I wonder if something like this could be done: Somewhere in ping(8): bool ping6_compat; if (strcmp(argv[0], "ping6")) { ping6_compat =3D true; } =2E.. if (ping6_compat) { do_this(); } else {} do_that(); } And sbin/ping/Makefile: LINKS+=3Dsbin/ping sbin/ping6 (Note that I didn't check if sbin/ping/Makefile already set LINKS. If it doesn't, it'd be "LINKS=3D", of course.) Then, ping(8) and ping6(8) still are the same binary and backwards compat is maintained, at least until spray paints the neon pink bike shed. (Note: I am in no way saying this discussion is a bike shed. I'm _only_ making a joke as a nod to the idiomatic expression.) Thanks, --=20 Shawn Webb Cofounder / Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 Tor+XMPP+OTR: lattera@is.a.hacker.sx GPG Key ID: 0xFF2E67A277F8E1FA GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 --63e6t6wtjncgu5iy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAl1jOigACgkQ/y5nonf4 4frgYw/9ELxk7ab6jWJaadj3jql60yKBQMcPEiLCzd1UZYe3528CKs1TIKPnbN7x mTAhEusRs/GJabiQaB9rbhKgWgKv293wsGXV1t/NW/AwQS6o0DWrFXrCaTI3wIkU Oj+EFw4amq0bHlxRnk/fDGRC+JIcL0WljGAd0WUzzFzPkd/3KHNjXS8He4shk3kc ld2YWPyNzjH4NqMItouqeJlJZw9HvTIxdsW1jle33QJKI3087ZBK76IJmIhA14um xU5WW0yJmjpryalnX3s38jsOPOUeer1CbyE06QKwB+13S5T+eBo1YAgu3sQ0dhRQ jf30hcN/AwtwVihh4a22c/yztW4avL2C1EXGmJrQjnfSN5O0a1afEM/TUoD/6ChR XwO6aAC8djEP9VZsVKV9IVwKpCUcOMlE252JKLCigMpKNf+0SvUQi+SJzOBPA+pB +X2eRO9oHMO2fssAP6wqlNqhI+0lveTVPORFSjmCqIBKezDMeLJLDd23CbyC32d+ mtpU3NOCafiYGMXT26KcI5/a8aRtK8BgwCFoyLxDr82ro/Kly5TXTrULET5w0iqJ wrQ6l5qc7qZIHHX0DWq+BdX84KM4s8CkRqKQY01Vi8qqkVxbpCGU7DSNQcdA0q2t 2jfGNpqEPe0mBCHMX3cd0Gc1s1OaD/udTRR8sMC6Qh6lBaB0Fl4= =6BTW -----END PGP SIGNATURE----- --63e6t6wtjncgu5iy--