From owner-freebsd-hackers Sat Oct 19 12:10:26 2002 Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 64A6937B40D; Sat, 19 Oct 2002 12:10:25 -0700 (PDT) Received: from harrier.mail.pas.earthlink.net (harrier.mail.pas.earthlink.net [207.217.120.12]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1A77443E75; Sat, 19 Oct 2002 12:10:21 -0700 (PDT) (envelope-from tlambert2@mindspring.com) Received: from pool0132.cvx22-bradley.dialup.earthlink.net ([209.179.198.132] helo=mindspring.com) by harrier.mail.pas.earthlink.net with esmtp (Exim 3.33 #1) id 182yyy-0000BP-00; Sat, 19 Oct 2002 12:09:57 -0700 Message-ID: <3DB1ADBD.3D65B120@mindspring.com> Date: Sat, 19 Oct 2002 12:08:45 -0700 From: Terry Lambert X-Mailer: Mozilla 4.79 [en] (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: Poul-Henning Kamp Cc: Maxim Sobolev , hackers@FreeBSD.ORG, dillon@FreeBSD.ORG Subject: Re: Patch to allow a driver to report unrecoverable write errors to the buf layer References: <28472.1035014051@critter.freebsd.dk> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Poul-Henning Kamp wrote: > Yes, I noticed that appeared at some time. That misfeature should be > removed in toto. > > If a retry can solve the issue, it's the drivers responsibility to > retry as much as makes sense and then fail if it doesn't work. > > Neither the buf nor the bio layer should get involved in those > retries. > > If you really want to change the behaviour here, you should add a flag > on the buf going down, saying "Never, ever retry". How do you tell the disk not to automatically retry, resulting in bad sector sparing, using this approach? Media perfection happens at all layers in the I/O subsystem, not just at the very bottom or the very top. -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message