From owner-cvs-src-old@FreeBSD.ORG Thu Sep 24 07:12:15 2009 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 94C701065672 for ; Thu, 24 Sep 2009 07:12:15 +0000 (UTC) (envelope-from avg@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 823538FC19 for ; Thu, 24 Sep 2009 07:12:15 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id n8O7CFo8077451 for ; Thu, 24 Sep 2009 07:12:15 GMT (envelope-from avg@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id n8O7CFl6077450 for cvs-src-old@freebsd.org; Thu, 24 Sep 2009 07:12:15 GMT (envelope-from avg@repoman.freebsd.org) Message-Id: <200909240712.n8O7CFl6077450@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to avg@repoman.freebsd.org using -f From: Andriy Gapon Date: Thu, 24 Sep 2009 07:11:23 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/amd64/pci pci_cfgreg.c src/sys/dev/pci pcireg.h src/sys/i386/pci pci_cfgreg.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Sep 2009 07:12:15 -0000 avg 2009-09-24 07:11:23 UTC FreeBSD src repository Modified files: sys/amd64/pci pci_cfgreg.c sys/dev/pci pcireg.h sys/i386/pci pci_cfgreg.c Log: SVN rev 197450 on 2009-09-24 07:11:23Z by avg number of cleanups in i386 and amd64 pci md code o introduce PCIE_REGMAX and use it instead of ad-hoc constant o where 'reg' parameter/variable is not already unsigned, cast it to unsigned before comparison with maximum value to cut off negative values o use PCI_SLOTMAX in several places where 31 or 32 were explicitly used o drop redundant check of 'bytes' in i386 pciereg_cfgread() - valid values are already checked in the subsequent switch Reviewed by: jhb MFC after: 1 week Revision Changes Path 1.116 +8 -8 src/sys/amd64/pci/pci_cfgreg.c 1.74 +1 -0 src/sys/dev/pci/pcireg.h 1.135 +7 -7 src/sys/i386/pci/pci_cfgreg.c