From owner-freebsd-current@FreeBSD.ORG Mon May 24 17:24:21 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DA9DE16A4CE for ; Mon, 24 May 2004 17:24:21 -0700 (PDT) Received: from sdf.lonestar.org (ol.freeshell.org [192.94.73.20]) by mx1.FreeBSD.org (Postfix) with ESMTP id 4B75243D2F for ; Mon, 24 May 2004 17:24:21 -0700 (PDT) (envelope-from luked@pobox.com) Received: from sdf.lonestar.org (IDENT:lukas@otaku.freeshell.org [192.94.73.2]) by sdf.lonestar.org (8.12.10/8.12.10) with ESMTP id i4P0NdPY002911; Tue, 25 May 2004 00:23:40 GMT Received: from localhost (lukas@localhost)i4P0NdSe024018; Mon, 24 May 2004 17:23:39 -0700 (PDT) X-Authentication-Warning: otaku.freeshell.org: lukas owned process doing -bs Date: Mon, 24 May 2004 17:23:39 -0700 (PDT) From: Luke X-X-Sender: lukas@otaku.freeshell.org To: Jon Noack In-Reply-To: <40B18C47.9080102@alumni.rice.edu> Message-ID: References: <200405232109.aa46210@salmon.maths.tcd.ie> <40B18C47.9080102@alumni.rice.edu> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: Ian Dowse cc: current@freebsd.org Subject: Re: USB patch for better bus_dma and detachment support X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: LukeD@pobox.com List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 May 2004 00:24:22 -0000 On Mon, 24 May 2004, Jon Noack wrote: > On 05/23/04 22:31, Luke wrote: > > On Sun, 23 May 2004, Ian Dowse wrote: > > > >> In case anybody is interested in testing or helping with this, > >> there's a patch at > >> > >> http://people.freebsd.org/~iedowse/usb.diff > >> > >> that attempts to begin addressing a number of problems with our > >> current USB code: > > > > I'd love to try this out. I'm using a Netgear FA120 USB ethernet > > adapter with the axe driver, and my kernel panics with a page fault > > in usb_transfer_complete every time I attempt to bring the interface > > down. This means I can't reboot without a panic. It looks like this > > code might address my problem. > > > > I've never tested a patch in this manner before though. I assume > > there's some utility like mergemaster to merge this into my existing > > code. If somebody can tell me how to merge in these changes I'll try > > them out this week and let you know how it goes. > > The utility 'patch' is what you need to use. Check out the patch(1) man > page. Something like the following should work (I haven't tried this): > > cd /usr/src/sys/dev/usb > patch -p0 < usb.diff > > After applying the diff just rebuild and test. > > NOTE: you will have to reapply the diff after every CVSup (and possibly > other update schemes). > > Jon Noack Thanks. I applied the patch, rebuilt and reinstalled the kernel, and I can see no difference. My system still hangs with the same page fault in usb_transfer_complete when I attempt to shut it down or bring down the network interface on my USB device. The disconnecting/reconnecting behavior appears unchanged as well, though it seems to detect the reconnection a little faster... that might just be my imagination though. It was plenty fast to start with. I'm using ohci. I don't believe I mentioned that earlier.