Date: Sat, 08 Jul 2017 15:33:45 +0200 From: Matthew Rezny <rezny@freebsd.org> To: Jan Beich <jbeich@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r445076 - in head/x11-servers: xorg-nestserver/files xorg-server xorg-server/files xorg-vfbserver/files xwayland/files Message-ID: <9096793.VZMgiYpJva@workstation.reztek> In-Reply-To: <o9sv-9k91-wny@FreeBSD.org> References: <201707051241.v65CfvFD096993@repo.freebsd.org> <1759815.Tk37oZ9O8z@workstation.reztek> <o9sv-9k91-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Saturday 08 July 2017 14:38:18 Jan Beich wrote: > Matthew Rezny <rezny@freebsd.org> writes: > > Since fcntl is used to add FD_CLOEXEC after the unlink, there is zero > > functional difference between using mkstemp and mkostemp with O_CLOEXEC. > > Therefore, the the patch is entirely unnecessary cruft. > > Not zero, see existing HAVE_MKOSTEMP check in hw/xwayland/xwayland-shm.c. > This change was about *atomic* close-on-exec. Anyway, I've sent a better > version upstream. That is a point that could have been made clear in a PR. Saying "like Linux" in the commit message did not make that intent clear. Please open a PR with the better version or provide a link to the patch proposed upstream.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9096793.VZMgiYpJva>