From owner-svn-src-all@FreeBSD.ORG Mon Mar 19 01:52:08 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 674ED1065676 for ; Mon, 19 Mar 2012 01:52:08 +0000 (UTC) (envelope-from jhellenthal@dataix.net) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id DAFBB8FC12 for ; Mon, 19 Mar 2012 01:52:07 +0000 (UTC) Received: by iahk25 with SMTP id k25so12189833iah.13 for ; Sun, 18 Mar 2012 18:52:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dataix.net; s=rsa; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to; bh=xG6hlcWyhxQLTPxUfA9nTmQzEO3spsOmgd4YXYWJV7o=; b=JSeJE+P93+DKttHbq+q4opIAFoa1Vc4GZ8ws297hTRC5jE1/uVRTyfCNrGaLb+Nb2w T0z2qv8PrOyB3URyXXCGJ5ocf9nbkDY+s0f4R4+yZvkyd6IHRlSR9/XM8s3i2jJLSSdg IeTU64h7enPNg/Wuwl4GkVYg4yrqXA7Vj1xrE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:x-gm-message-state; bh=xG6hlcWyhxQLTPxUfA9nTmQzEO3spsOmgd4YXYWJV7o=; b=Au4HPTvjM33AykmAsu44m7o6/Mss6gNnap4GFFVo48FyNbSWRL+YrQwD4ufRGgcgez cSEHZwH5sdRWda8P0o1w5PvbYpShPyiA4gxNbmxYR19N5liVtBIMzIKiFIP9hVjQSrbq upX1M9n3vHlZ61RYh3Ua9PhEZKBTcxMiroyb0DscrYfMMf6IaCC1asFciH9wwWrXlOsz prP3dxZF3C3894pwEoblqKqIZyNI/J3q146moekV1OGTDaUhYa8tIxGQYJldXsmEeQKY bYezfPiBgf66+Y1ozDAXhOuPaRvc6sOyndZrxZJEFftDlgDy6UbjhlWDxhKoQQ2ZSJ/m PrjA== Received: by 10.50.161.232 with SMTP id xv8mr4943476igb.9.1332121927191; Sun, 18 Mar 2012 18:52:07 -0700 (PDT) Received: from DataIX.net (adsl-99-112-214-41.dsl.klmzmi.sbcglobal.net. [99.112.214.41]) by mx.google.com with ESMTPS id i7sm4962031igq.11.2012.03.18.18.52.05 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 18 Mar 2012 18:52:06 -0700 (PDT) Received: from DataIX.net (localhost [127.0.0.1]) by DataIX.net (8.14.5/8.14.5) with ESMTP id q2J1q3eR059729 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 18 Mar 2012 21:52:03 -0400 (EDT) (envelope-from jhellenthal@DataIX.net) Received: (from jhellenthal@localhost) by DataIX.net (8.14.5/8.14.5/Submit) id q2J1q3wF059660; Sun, 18 Mar 2012 21:52:03 -0400 (EDT) (envelope-from jhellenthal@DataIX.net) Date: Sun, 18 Mar 2012 21:52:03 -0400 From: Jason Hellenthal To: Eitan Adler Message-ID: <20120319015203.GB13456@DataIX.net> References: <201203190127.q2J1RtgB044557@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="uQr8t48UFsdbeI+V" Content-Disposition: inline In-Reply-To: <201203190127.q2J1RtgB044557@svn.freebsd.org> X-Gm-Message-State: ALoCoQmFioZMEMDkjsNn3zsrmyb5nFVFR+yPr9XW4dYLcEOTHgq+rDRrCLEMTO6IcmRJqYo54mhE Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-8@freebsd.org Subject: Re: svn commit: r233147 - stable/8/lib/libc/string X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Mar 2012 01:52:08 -0000 --uQr8t48UFsdbeI+V Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 19, 2012 at 01:27:55AM +0000, Eitan Adler wrote: > Author: eadler > Date: Mon Mar 19 01:27:55 2012 > New Revision: 233147 > URL: http://svn.freebsd.org/changeset/base/233147 >=20 > Log: > MFC r232503: > POSIX mandates that swab do nothing when len < 0 > =20 > PR: 140690 > Approved by: cperciva >=20 > Modified: stable/8/lib/libc/string/swab.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- stable/8/lib/libc/string/swab.c Mon Mar 19 01:27:30 2012 (r233146) > +++ stable/8/lib/libc/string/swab.c Mon Mar 19 01:27:55 2012 (r233147) > @@ -45,6 +45,8 @@ swab(const void * __restrict from, void=20 > int n; > char *fp, *tp; > =20 > + if (len <=3D 0) > + return; Does this not test to see if it is also equal to 0(zero) ? If I understand the above statement "POSIX mandates that swab do nothing when len < 0" then the above code should be exactly that ... and not testing whether it is equal to zero... > n =3D len >> 1; > fp =3D (char *)from; > tp =3D (char *)to; > _______________________________________________ > svn-src-stable-8@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/svn-src-stable-8 > To unsubscribe, send any mail to "svn-src-stable-8-unsubscribe@freebsd.or= g" --=20 ;s =3D; --uQr8t48UFsdbeI+V Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJPZpFCAAoJEJBXh4mJ2FR+yNUH/j7hn/2z1yoIcP0Tbux7lQaT Y/z3W+dXCGGFuDkyIsoAQBF7zDAXqjUxjj0g/qJWakdq+SaRJA65v2AV8d1CYDbf fFlv5JY9UsDpjyHD4Z2r33Xk2hgTB8lDyJLEgFrPhbS3x9AY9euQ6oE1TS0R3J3/ 8I3Zde+MlU0c2g7ST3lZA4cKsKB8asl+fBd9NdpR7T7emryrLx2pjO+9ff9jeqpZ Sol1QnVWzgTbHkJVrM2GM3Y/1mWdpkCLa4yYNAW20u0y7/KX/Z5fNeBUZVHYFoDV wM8oioLDHhVc9d2fuWd6QaEwM5YYyh9BMC3SGALPNAAgIKwd1iOuDixKeufkmDg= =4Hc8 -----END PGP SIGNATURE----- --uQr8t48UFsdbeI+V--