From owner-freebsd-hackers@freebsd.org Sat Dec 22 07:14:11 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 515621348298 for ; Sat, 22 Dec 2018 07:14:11 +0000 (UTC) (envelope-from yuripv@yuripv.net) Received: from wout2-smtp.messagingengine.com (wout2-smtp.messagingengine.com [64.147.123.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 0BE22743B5; Sat, 22 Dec 2018 07:14:09 +0000 (UTC) (envelope-from yuripv@yuripv.net) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id E8A4B1223; Sat, 22 Dec 2018 02:14:01 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sat, 22 Dec 2018 02:14:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yuripv.net; h= subject:to:cc:references:from:message-id:date:mime-version :in-reply-to:content-type; s=fm3; bh=0GB3jw4CG2gr+oN35GsW15zDo10 uKkvOVxtbbBYULLI=; b=BFnfENEXxsbO/K3csZE+Y3oFUACITjDCoFYRPprdA5g zrUwDwImw84TlqxhrDDjUGdGlAMJEOv8W7J7Zec0Bnpy6DBV9+445m1jB/E8jY4y qWn4btKJLvjigbKBjo15x7pNtOl+1OsM/7g6WnHAPQYz/NsR2+JyJC9HwLmNHSK7 aLO1qsqH6QXFPYZh266TPNcxsS8zgb2oNUdrILjpTqlTj5O9YlZ9Ic3sUxG5O1bq H4Mm4aLJ4n8p2wJkET4tG0ukmWobnlpU036BoFl5NQbkid2w0f4o2OOXVg7KZLJD dxySVIjjYkfMacod8SuG2Obw+u9zyQqRAFslAWwI33Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=0GB3jw 4CG2gr+oN35GsW15zDo10uKkvOVxtbbBYULLI=; b=epg3nJtYaQduGL4pfP4aeC mCc/KKRJGcCyIjLsjpmB9pWJb8rr2zwDf/cwyP9gXDYJQ3/eLWXEkWsV+Ejktw3e WuYx3qud3MoVqfDy4UYSd5/75BBjpJS2PUZqxHPGG2bqO3Fb7YkaeL9Jg0W1kaAk hHh/kyN4TpoSOnra4yspTfqW7sKO9C+IcQmlcP9SozwCLOj8GMHFdtWD9Qorkvhc Wk3nR5tGvyPAdDDxxhwtLKANLvbVClMBs2B2nyZHDHhGeMkrcSK/z5QkJ5X+Uz0w VPZEXDemBndvx1/9f4XlRbvdhGZusOv1YD6vl9Cz09ot3tGCTtcv08qZpcoJ2EEQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudejiedguddtiecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfhuthenuceurghilhhouhhtmecu fedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepuffvfhfhkf fffgggjggtsehgtderofdtfeejnecuhfhrohhmpegjuhhrihcurfgrnhhkohhvuceohihu rhhiphhvseihuhhrihhpvhdrnhgvtheqnecuffhomhgrihhnpehfrhgvvggsshgurdhorh hgnecukfhppeelgedrvdeffedrvdefuddrudelheenucfrrghrrghmpehmrghilhhfrhho mhephihurhhiphhvseihuhhrihhpvhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from [192.168.1.2] (unknown [94.233.231.195]) by mail.messagingengine.com (Postfix) with ESMTPA id A6ACFE40E1; Sat, 22 Dec 2018 02:13:59 -0500 (EST) Subject: Re: is adding new private symbols to libc frowned upon? To: Kyle Evans , Konstantin Belousov Cc: freebsd-hackers References: <20181222064138.GM60291@kib.kiev.ua> From: Yuri Pankov Openpgp: preference=signencrypt Autocrypt: addr=yuripv@yuripv.net; keydata= mQENBFu8u6IBCADB11gP0QwnorrHjqAtKLHKHNHskhy0s7jqJKfx0YqXgVBKGLJ9/mjLAz0F CBNvemHSDDTs0mEZ9cBKKi6cmsav6+UQgr//yai6hvXLBJqKchSFO4MhmdvBtsGFq1yKz5Zi uhjmimKyIpgBgvMdbgGbGq6cnSB2uEPmZuJr419SVRODOkXukU+F5WHgaHzDdHAIu1asCt2B +6msxqIqlFWcXyZyTGicTGGvC/PFIsVRUtD1dIJANTC876g7DTb7LZXWiWwJpSJ4GKMXMHVX Ct9BoQ4i3nhKbOxb6Io1wsy+NFyWsTJ9KYrxKKPJP3oG8BWb/cqlFqnE4eNSsiq2q7krABEB AAG0H1l1cmkgUGFua292IDx5dXJpcHZAeXVyaXB2Lm5ldD6JAVQEEwEKAD4WIQT4arc+w94t Pi0v/3CTi+B/sSrhbAUCW7y7ogIbAwUJBaOagAULCQgHAwUVCgkICwUWAwIBAAIeAQIXgAAK CRCTi+B/sSrhbJ+ACACqOlkjZ+iP8K8hcwz/G6+c1lVkhuMWL+hxFeE149QuJAXQvkOj/UXO 7jY9HSqFbOYYY44/hujpQCu+/u2dsJ5MAA7TJspWK2zUxtFAzgDp1fRXmCvMlFLdI0yVkKOB JaK+HQP8rBT6yHzGw1KJ6VyOXuuD0Kx02Ou61qjG9/vPRR0jtaxog0rKxpf+yf0UvSM4vb7+ LdY2GQxgfcLcJ8hThR4ElWJAkDsG4CiXixGJuFJ+9dpMK6LHmP6M+NxV4NkzpNddn3Eii8XQ y5spxcLszp8csFBDtAC6BI9sHLhJ9Va1VKpuvSlDsBv4ZtsjnUCIaOiF5MDTYkddSPGGMBck uQENBFu8u6IBCADKih3Q933rDNj4ZA8FhBQ2RlmBgvwOLcDPIL3h0V7h38y3+HisgFScXACD sdrTlYZ1bRXkD9FHENynBcv0l/3uGJDk8jaGIDE0TP8OQBRp+IaU9/BHnAqrKxTJGIolDahy 2m+yx2yhdc6B4ujWMDqCF1rWOD+ymOWw+VLllOkrHcZa5PJtX9UOGbApZl8ZTM8El4CANN8F 1bg9MWzUi+8LYoGWGc+BwsFS1OUB1c4SPgMu5fD4Wfsr9yRl06fdpEA2YT7B/j5/5RSC0sE2 Zs/tmJ/JRflHJ12ycj59ma2xQMfEJF40hZDpMFQmZvbVqgEg3ocQcltjbxlIKZ/mjC4zABEB AAGJATwEGAEKACYWIQT4arc+w94tPi0v/3CTi+B/sSrhbAUCW7y7ogIbDAUJBaOagAAKCRCT i+B/sSrhbIDcCACqAZMcoxUBLZa40a5b24j5i1jplvCYYb3h+Q5lt5+BFJ87kCb4dJuUD3kh 2i29BrxWQWa9WNue9ozxeYkbkfXubQYXexVolRsnh64OdGsE8KvorBFBB3zdK/GRt2Jy+jsn TfUWuQllbzMP0MfhCDMk1Mo8WvDH2/cOEP/yLKf20a+cd6nLs7bidjmGXo9pyuBKAtV6Kv+V Ru54AL+A/UBYu/eB3Dtvzcnut+1Zq6KaP++kUwPwINLIk04OBDwN0zRNTiqMAFYYyz2vZHBB 6E1th/l//ZC5b9Dk0ZpFI1bYdL9ymnrZe1MqbGPnDCToQxu00T/pZCm6Z92YrZQYuNwl Message-ID: <352cae97-2e25-3302-0e4e-e75d4b4b3225@yuripv.net> Date: Sat, 22 Dec 2018 10:13:41 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="9RW5owgLvSLpQp7OD8PjwfiyBRvAHcYYN" X-Rspamd-Queue-Id: 0BE22743B5 X-Spamd-Bar: -------- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=yuripv.net header.s=fm3 header.b=BFnfENEX; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=epg3nJtY; spf=pass (mx1.freebsd.org: domain of yuripv@yuripv.net designates 64.147.123.25 as permitted sender) smtp.mailfrom=yuripv@yuripv.net X-Spamd-Result: default: False [-8.16 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:64.147.123.25]; HAS_ATTACHMENT(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[yuripv.net:+,messagingengine.com:+]; MX_GOOD(-0.01)[cached: in2-smtp.messagingengine.com]; NEURAL_HAM_SHORT(-0.98)[-0.983,0]; SIGNED_PGP(-2.00)[]; FROM_EQ_ENVFROM(0.00)[]; IP_SCORE(-3.47)[ip: (-9.00), ipnet: 64.147.123.0/24(-4.50), asn: 11403(-3.78), country: US(-0.08)]; MIME_TRACE(0.00)[0:+,1:+,2:+]; ASN(0.00)[asn:11403, ipnet:64.147.123.0/24, country:US]; RCVD_TLS_LAST(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[25.123.147.64.list.dnswl.org : 127.0.5.1]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[yuripv.net:s=fm3,messagingengine.com:s=fm1]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.20)[multipart/signed,multipart/mixed,text/plain]; SUBJECT_ENDS_QUESTION(1.00)[]; DMARC_NA(0.00)[yuripv.net]; TO_MATCH_ENVRCPT_SOME(0.00)[] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Dec 2018 07:14:11 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9RW5owgLvSLpQp7OD8PjwfiyBRvAHcYYN Content-Type: multipart/mixed; boundary="LYW4qOyL853LutqVKVOrNn92HCEK76Sb6"; protected-headers="v1" From: Yuri Pankov To: Kyle Evans , Konstantin Belousov Cc: freebsd-hackers Message-ID: <352cae97-2e25-3302-0e4e-e75d4b4b3225@yuripv.net> Subject: Re: is adding new private symbols to libc frowned upon? References: <20181222064138.GM60291@kib.kiev.ua> In-Reply-To: --LYW4qOyL853LutqVKVOrNn92HCEK76Sb6 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Kyle Evans wrote: > On Sat, Dec 22, 2018 at 12:42 AM Konstantin Belousov > wrote: >> >> On Sat, Dec 22, 2018 at 04:38:52AM +0300, Yuri Pankov wrote: >>> Essentially, I need the __collate_equiv_value symbol to be visible to= >>> libregex for the changes in https://reviews.freebsd.org/D18531. Is t= he >>> following change OK (it works, at least), or should try to avoid that= ? >>> >>> --- a/lib/libc/locale/Symbol.map >>> +++ b/lib/libc/locale/Symbol.map >>> @@ -212,6 +212,7 @@ FBSD_1.3 { >>> FBSDprivate_1.0 { >>> _PathLocale; >>> __detect_path_locale; >>> + __collate_equiv_value; >>> __collate_load_error; >>> __collate_range_cmp; >>> }; >>> >> Then libregex must always match the installed libc. >> >> I looked at the the libregex/Makefile and my question is, what is the >> difference between exports from libc/regex vs. libregex. Can libregex= >> become ELF filter for libc ? >> >=20 > libregex is going to be getting more complicated [1] after a couple > more exp-runs. I can possibly re-work it to make a filter work > (perhaps?), but I'm not sure how badly that will impact the > performance of libc regex. >=20 > [1] https://reviews.freebsd.org/D12935 I don't think making libregex a filter for libc will work here as you intend it to have different functionality, even if compiling the same source files. OTOH, the function isn't easily decoupled from libc (if at all) as it needs to know internal implementation details, hence my original question= =2E --LYW4qOyL853LutqVKVOrNn92HCEK76Sb6-- --9RW5owgLvSLpQp7OD8PjwfiyBRvAHcYYN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEE+Gq3PsPeLT4tL/9wk4vgf7Eq4WwFAlwd5CUACgkQk4vgf7Eq 4Wz7Rwf+PVHFP/S1MqTzY6tzexeIcOWwpz+nXDVYVbJ8OIUwjxy1Inv+o0Re6k0Y LRa7uSfbb0vLbLExcYodmQ7zFJ+LLqJU10xZHpkmLRSxKFecZUvg8hijyuNX6KLh F8D5jbT9BATmms9EwJnc/6BqVdY2DC+Dpx2BvXA2DDjoSfT0HuPR+bJILwyGp+Kd zx/ZIXdyeKjzav3WNuU7SzNsm40HXdz4GySAUiTxWCjb8SwmwEL5rRQZ0Ln5xB9n blhHEcmWOd6fBqCrHTqbCP80N3q4226PtoC6a2zpa9XrWUDqf5V6x1EQzUKPSBUD t4w29DhGYwZMgXSER3BP+xNsnhEitQ== =hOLE -----END PGP SIGNATURE----- --9RW5owgLvSLpQp7OD8PjwfiyBRvAHcYYN--